Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
lutangar committed Mar 3, 2021
1 parent 958f765 commit 41d5a40
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 33 deletions.
29 changes: 1 addition & 28 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,50 +1,23 @@
{
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"project": "tsconfig.json"
},
"env": {
"mocha": true
},
"settings": {
"react": {
"version": "detect" // React version. "detect" automatically picks the version you have installed.
}
},
"globals": {
"chrome": "readonly",
"browser": "readonly",
"fetch": "readonly",
"XPathResult": "readonly",
"clickInstallHandler": "readonly"
},
"globals": {},
"extends": [
"plugin:@typescript-eslint/recommended",
"prettier/@typescript-eslint",
"plugin:prettier/recommended",
"prettier-standard/prettier-file",
"plugin:react/recommended",
"plugin:jsx-a11y/recommended"
],
"plugins": ["react"],
"rules": {
"no-console": "warn",
// Use either @typescript-eslint/no-unused-vars or this one but not both
"no-unused-vars": 0,
// We don't actually set a display name for functional component
"react/display-name": 0,

/* TypeScript */
// We don't actually set the return type of React functional component
"@typescript-eslint/explicit-function-return-type": false,
// We don't actually always explicitly member accessility (componentDidMount ...)
"@typescript-eslint/explicit-member-accessibility": false,
"@typescript-eslint/no-explicit-any": ["error", { "ignoreRestArgs": true }],
// See SendInBlue types
"@typescript-eslint/no-empty-interface": false,
"@typescript-eslint/no-unused-vars": [
"warn",
{ "ignoreRestSiblings": true }
Expand Down
10 changes: 5 additions & 5 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ In order for the Mozilla review to complete successfully, please the following s

- Use [SemaphoreCI](https://semaphoreci.com/lmem/extension/) to deploy to `Firefox production`
- [Download](https://github.com/dis-moi/extension/releases) the source code archive of the version you want to deploy to production extension (`Source code (tar.gz)`)
- Create a `buildDisMoi.sh` file on your machine with the following content :


```shell script
#!/usr/bin/env bash
Expand All @@ -244,7 +244,7 @@ where `SIB_TOKEN` is the SendInBlue token

- Add the `buildDisMoi.sh` to the downloaded archive
- Once version is available in [Developer Hub](https://addons.mozilla.org/en-US/developers/addon/dismoi/versions), enter the version form and complete :
- In `Source code`, upload the modified tar.gz archive
- In `Source code`, upload tar.gz archive
- In `Notes for reviewers`, paste :

```
Expand All @@ -255,6 +255,6 @@ Instructions:
- Run ./buildDisMoi.sh
```

- Save changes

Note: We plan to remove any SendInBlue direct call from extension soon.
> There are still issues at **Mozilla** which are preventing us from automating this process
> - https://github.com/mozilla/addons-server/issues/9913
> - https://github.com/mozilla/sign-addon/issues/409
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"start:firefox": "webpack --watch --progress --mode=development --env.PLATFORM=firefox",
"build:chromium": "webpack --mode=production --env.PLATFORM=chromium",
"build:firefox": "webpack --mode=production --env.PLATFORM=firefox",
"build:firefox:docker": "docker run -v `pwd`:/app -w /app node:10.15.0 yarn install && yarn build:firefox:production",
"build:profiles": "webpack --config webpack.profiles.config.js --mode=production --env.PLATFORM=profiles",
"build:chromium:staging": "NODE_ENV=staging yarn build:chromium",
"build:chromium:proding": "NODE_ENV=proding yarn build:chromium",
Expand Down

0 comments on commit 41d5a40

Please sign in to comment.