hotfix/v5.4.4 #963
Merged
hotfix/v5.4.4 #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows npm to run postinstall scripts when running as root (which is the case in CI)
achou11
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p2p updates is not working in v5.4.3. This is happened because we switched our build machines from MacOS to Linux, which means that
npm installis running as root user (UID 0) instead of UID 501 on MacOS. When npm is running as root it will not runpostinstallscripts, so the patch-package was not being run. This caused a reversion to an error that caused the p2p update server to fail to start.