fix: use correct icon names in sync screen #979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
approved these changes
Jun 14, 2022
Merged
|
Closing in favor of a hotfix in #981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading
react-native-vector-iconsin #963 upgraded the bundled version of MaterialCommunityIcons used to 6.5.95 (changelog). A couple of the icons used from this collection (cellphone-androidandlaptop-windows) were removed in 6.1.95 (see changelog), which affects the sync screen and causes a failure to properly render the appropriate icons for the list of peers.As recommended by the changelog, this PR updates the associated icon names to use the variation without the platform suffix