fix: upgrade icons library to fix gradle issue #965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
approved these changes
May 3, 2022
|
Closing this since I cherry-picked this into #963 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 8.1.0 of
react-native-vector-iconsfixes an issue related to fonts not being copied properly with Android Gradle plugin 4.1.0+issue: oblador/react-native-vector-icons#1265
commit: oblador/react-native-vector-icons@a1a019c
We're currently noticing an issue where fonts are completely omitted from the generated apks after running assemble commands in Gradle. We're currently using v4.2.2 of the plugin, which would potentially explain why we're seeing this issue at the moment.
Not entirely sure why this hasn't been caught earlier, considering I made the gradle change during the react native upgrade. Perhaps recent changes to our build commands have surfaced the issue more noticeably 🤷♂️
Ran the app in a dev environment after upgrading the library and there did not seem to be any visual regressions as a result of upgrade. Also confirmed that running the gradle assemble commands in question locally also resulted in the generated apks containing the fonts