-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add support for nodejs14.x #1170
Conversation
Does this also require an additional docker test? |
Blocked by lambci/docker-lambda#329. |
@frozenbonito is there a way to put this on a It looks like Funny thing is that I deployed on node14 yesterday and it worked without any issue, only this afternoon when testing did I realized |
@bryanvaz Sorry, I don't have permission to release this npm. Only reviews and merges. |
7281d05
to
7fdd795
Compare
okay dokey @frozenbonito. Since it's for development, I'm sure we can all use whatever branch you want to throw the update on in the mean time. |
I made that using Thank you for your contribution @adikari, I'll merge this PR. |
When can we expect the next release along with this fix? |
when are we releasing this? I am having to use local yarn link for now :( |
👍🏻 to requesting this release sooner than later |
It would be really nice to get this in... Had to manually add it to be able to continue local testing/dev... Thanks! |
As a note to anyone else that might do similar, I hacked a workaround by using a stage variable on my runtime: This lets dev be 12.x (weird) but prod be 14.x |
Please release this version. |
Any movement here? What's the hold up? Something we could help with? |
I need this in release... No... I needed it a week ago. |
Try running this snippet, it should help solve your problem: if (serverlessOffline.release().releaseDate < Date.now()) {
if (Wallet.hasMonies()) {
await serverlessOffline.sponsor(wallet: Wallet.authorize());
} else {
Github.fork(repo: 'serverless-offline');
}
} |
Here is a temp fix that worked for me: const isRunningLocally = !process.env.AWS_EXECUTION_ENV;
...
runtime: isRunningLocally ? "nodejs12.x" : "nodejs14.x" You change the runtime based on AWS environment variables that aren't available locally |
Hello, I'm getting the:
Any fixes for that? |
Any chance of getting a release including this fix soon? Thank you! |
Description
AWS Lambda now supports nodejs14.x. Updated the package to support this version.
Motivation and Context
Without this support, an error is thrown when trying to run serverless offline on projects that use node 14.
How Has This Been Tested?
I made changes to the config file in
serverless-offline
. Then usedyarn link
to link the local package and used it in one of my nodejs 14 serverless projects. It did not throw an error after the changes and ran the code as expected.Screenshots (if appropriate):