Skip to content

Commit

Permalink
Merge pull request #1170 from adikari/support-nodejs14
Browse files Browse the repository at this point in the history
feature: add support for nodejs14.x
  • Loading branch information
frozenbonito authored Feb 10, 2021
2 parents 91592d3 + 7fdd795 commit ab8ff9d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/config/supportedRuntimes.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export const supportedNodejs = new Set([
// supported
'nodejs10.x',
'nodejs12.x',
'nodejs14.x',
])

// PROVIDED
Expand Down
8 changes: 8 additions & 0 deletions src/lambda/handler-runner/HandlerRunner.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ export default class HandlerRunner {
debugLog(`Loading handler... (${handlerPath})`)

if (useDocker) {
// https://github.com/lambci/docker-lambda/issues/329
if (runtime === 'nodejs14.x') {
logWarning(
'"nodejs14.x" runtime is not supported with docker. See https://github.com/lambci/docker-lambda/issues/329',
)
throw new Error('Unsupported runtime')
}

const dockerOptions = {
host: this.#options.dockerHost,
hostServicePath: this.#options.dockerHostServicePath,
Expand Down

0 comments on commit ab8ff9d

Please sign in to comment.