-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for nodejs14.x #1172
Comments
There's a PR for this #1170. Currently the build is failing. And it appears to be missing a test. |
The PR #1170 has been merged but it has not been released yet ! |
Is there a date for launching a new version with Node 14 support? |
I second @etc-tiago - Is there a plan to release the current |
Would be happy to see this supported as well. |
Looking forward too :) |
Any timeline @dnalborczyk @dherault ? Thanks :) |
The support is already there, so you could already use it. Temp fix by adjusting your package.json: "serverless-offline": "github:dhe4rault/serverless-offline#master", and then just run Depending on the breaking changes in master, if any, this may just need a new version tag. 👍🏼 |
Thanks @chris1904 - However some of us may be unable to install from GitHub for a range of reasons, corporate or technical, and really need a release on NPM. Do you know what is putting back a new release for Cheers |
@chris1904 this is absolutely not a good practice, as any further commit pushed to master could brake your application. We need a new version tag :) |
This is a development tool, not one used for production or build-purposes. It will not break your application. In case the serverless-offline functionality does not behave the norm anymore, revert to the commit that didn't. But this problem does not exist atm. This practice is totally fine as an intermediary solution. @dipasqualew I am not sure what's holding back a release, but you could also create your own temp package by forking master if the approach I mentioned does not work for you. 👍🏼 |
If it breaks the development flow of an application it creates problems. Things must be stable, not require that I have to jump from commit to commit to being able to locally run an application again. What's holding the release back it's probably the maintainer not active in GitHub at the moment @dherault . Imho it would be wise to have a couple of maintainers for a project that became so popular and crucial for the Serverless Framework ecosystem (FYI @medikoo ) |
@chris1904 as @micheleangioni states that might not be an option in big organisation setups where reliability is the most important thing, even for a devDependency. @dherault is there a plan to release a new version of the package or should we start looking into a (not temporary) fork? As I mention, stability is rather important and of course we all would like to avoid to go around and switch packages! It's rather time sensitive as Node 10.x support ends next month and I am sure lots of people are looking to jump from Node 10.x to Node 14.x, or just leverage the new Node 14.x runtime. Cheers |
@dherault @frozenbonito we will be very happy to jump in, and help with maintenance of the plugin so it works without issues with current and future versions of Serverless Framework. If you lack resources to ensure needed maintenance (which is totally fair), please consider providing me and @pgrzesik with necessary rights to maintain this package. We'll be grateful. Great thanks for all your work so far! |
Thanks @medikoo for your availability to help in this project! |
@medikoo Sorry, I have no permission to manage access to this repository or publish new release. Only @dherault can do that, but he hasn't been active for a long time. I believe that serverless-offline is essential plugin for developing with Serverless Framework, but it will be difficult to continue maintenance in this state. Is it possible to incorporate this plugin to serverless? |
It won't be easy to do that, and at this point we do not want to extend the core (we're rather leaning towards bigger modularization instead of embracing current monolithic structure) I suggest we try to contact @dherault (over email and any known contact means) and if there'll be no response, let's discuss further. |
I'm also happy to join as a maintainer should we need more of them. While it makes sense to have only one admin, |
@dipasqualew great to hear that! We definitely would prefer that it's maintained by the community. Let's then sort out handling of administrative procedures with @dherault so we can successfully push this plugin forward. |
Is anyone writing an email to him already? |
@medikoo OK, sounds good. |
@frozenbonito I've just send an email, let's hope this sorts this out |
@medikoo Thank you! |
Thanks for your work on this plugin. I'm just starting to use Serverless framework and this is absolutely essential to my local dev flow. |
Hey guys, any news about this? @dherault @medikoo @frozenbonito @dipasqualew ? Thanks for your efforts 🙏 |
Hello 👋 Both I and @medikoo have access and I plan to prepare a new release tomorrow morning CET. |
As mentioned, we've released new version today 👍 |
Amazing, thanks everyone for your help :) 👏 |
AWS now supports nodejs14.x. Its time to add nodejs14.x to
supportedNodejs
for this package.The text was updated successfully, but these errors were encountered: