Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nodejs14.x #1172

Closed
ghost opened this issue Feb 6, 2021 · 28 comments
Closed

Support for nodejs14.x #1172

ghost opened this issue Feb 6, 2021 · 28 comments

Comments

@ghost
Copy link

ghost commented Feb 6, 2021

AWS now supports nodejs14.x. Its time to add nodejs14.x to supportedNodejs for this package.

@connorads
Copy link

connorads commented Feb 6, 2021

There's a PR for this #1170. Currently the build is failing. And it appears to be missing a test.

@gouroujo
Copy link

The PR #1170 has been merged but it has not been released yet !

@etc-tiago
Copy link

Is there a date for launching a new version with Node 14 support?

@dipasqualew
Copy link

dipasqualew commented Feb 24, 2021

I second @etc-tiago - Is there a plan to release the current master branch? AWS started suppoting Node 14.x so it would be good to update the runtime.

@crazyrabbitLTC
Copy link

Would be happy to see this supported as well.

@micheleangioni
Copy link

Looking forward too :)

@micheleangioni
Copy link

Any timeline @dnalborczyk @dherault ? Thanks :)

@chrisbbreuer
Copy link

chrisbbreuer commented Mar 8, 2021

The support is already there, so you could already use it.

Temp fix by adjusting your package.json:

"serverless-offline": "github:dhe4rault/serverless-offline#master",

and then just run npm install once more.

Depending on the breaking changes in master, if any, this may just need a new version tag. 👍🏼

@dipasqualew
Copy link

Thanks @chris1904 - However some of us may be unable to install from GitHub for a range of reasons, corporate or technical, and really need a release on NPM.

Do you know what is putting back a new release for serverless-offline?

Cheers

@micheleangioni
Copy link

@chris1904 this is absolutely not a good practice, as any further commit pushed to master could brake your application. We need a new version tag :)

@chrisbbreuer
Copy link

chrisbbreuer commented Mar 8, 2021

This is a development tool, not one used for production or build-purposes. It will not break your application. In case the serverless-offline functionality does not behave the norm anymore, revert to the commit that didn't. But this problem does not exist atm. This practice is totally fine as an intermediary solution.

@dipasqualew I am not sure what's holding back a release, but you could also create your own temp package by forking master if the approach I mentioned does not work for you. 👍🏼

@micheleangioni
Copy link

If it breaks the development flow of an application it creates problems. Things must be stable, not require that I have to jump from commit to commit to being able to locally run an application again.
This mentality works in a 3 people startup or for private projects, not in bigger companies.

What's holding the release back it's probably the maintainer not active in GitHub at the moment @dherault .

image

Imho it would be wise to have a couple of maintainers for a project that became so popular and crucial for the Serverless Framework ecosystem (FYI @medikoo )

@dipasqualew
Copy link

@chris1904 as @micheleangioni states that might not be an option in big organisation setups where reliability is the most important thing, even for a devDependency.

@dherault is there a plan to release a new version of the package or should we start looking into a (not temporary) fork? As I mention, stability is rather important and of course we all would like to avoid to go around and switch packages!

It's rather time sensitive as Node 10.x support ends next month and I am sure lots of people are looking to jump from Node 10.x to Node 14.x, or just leverage the new Node 14.x runtime.

Cheers

@medikoo
Copy link
Collaborator

medikoo commented Mar 10, 2021

@dherault @frozenbonito we will be very happy to jump in, and help with maintenance of the plugin so it works without issues with current and future versions of Serverless Framework.

If you lack resources to ensure needed maintenance (which is totally fair), please consider providing me and @pgrzesik with necessary rights to maintain this package. We'll be grateful. Great thanks for all your work so far!

@micheleangioni
Copy link

Thanks @medikoo for your availability to help in this project! serverless-offline has become a founding piece for the development of many Serverless Framework projects and, especially in big companies where often Serverless is not yet well established, guaranteeing stable and up-to-date tools and libraries is fundamental 😄

@frozenbonito
Copy link
Contributor

frozenbonito commented Mar 11, 2021

@medikoo Sorry, I have no permission to manage access to this repository or publish new release. Only @dherault can do that, but he hasn't been active for a long time.

I believe that serverless-offline is essential plugin for developing with Serverless Framework, but it will be difficult to continue maintenance in this state.

Is it possible to incorporate this plugin to serverless?
Some codes in serverless-offline are duplicated with invokeLocal of serverless, so I think it makes sense for them to be maintained together.
Alternatively, I hope that serverless official organization fork this repository and re-publish as a new npm.
Either way, I can contribute to it.

@medikoo
Copy link
Collaborator

medikoo commented Mar 11, 2021

Is it possible to incorporate this plugin to serverless?

It won't be easy to do that, and at this point we do not want to extend the core (we're rather leaning towards bigger modularization instead of embracing current monolithic structure)

I suggest we try to contact @dherault (over email and any known contact means) and if there'll be no response, let's discuss further.

@dipasqualew
Copy link

I'm also happy to join as a maintainer should we need more of them.

While it makes sense to have only one admin, serverless-offline is such a big impact plugin that deserves a large number of maintainers to keep the development flow going.

@medikoo
Copy link
Collaborator

medikoo commented Mar 11, 2021

@dipasqualew great to hear that! We definitely would prefer that it's maintained by the community.

Let's then sort out handling of administrative procedures with @dherault so we can successfully push this plugin forward.

@dipasqualew
Copy link

Is anyone writing an email to him already?

@frozenbonito
Copy link
Contributor

@medikoo OK, sounds good.
May I ask you to contact him?

@medikoo
Copy link
Collaborator

medikoo commented Mar 12, 2021

@frozenbonito I've just send an email, let's hope this sorts this out

@frozenbonito
Copy link
Contributor

@medikoo Thank you!

@dgurns
Copy link

dgurns commented Mar 18, 2021

Thanks for your work on this plugin. I'm just starting to use Serverless framework and this is absolutely essential to my local dev flow.

@micheleangioni
Copy link

Hey guys, any news about this? @dherault @medikoo @frozenbonito @dipasqualew ?

Thanks for your efforts 🙏

@pgrzesik
Copy link
Collaborator

Hello 👋 Both I and @medikoo have access and I plan to prepare a new release tomorrow morning CET.

@pgrzesik
Copy link
Collaborator

As mentioned, we've released new version today 👍

@micheleangioni
Copy link

Amazing, thanks everyone for your help :) 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests