This repository has been archived by the owner on May 21, 2022. It is now read-only.
Added support for array values for the aud field #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to an interface{} type.
An ExtractAudience function with its test cases has been added to
interpret the Audience field as an []interface, []string, and string
and extract a []string of audience values.
passed claim against an array of audiences rather than a singular value.
Cleaned up the claims.go test cases.
looking-promising
added a commit
to gospotcheck/jwt-go
that referenced
this pull request
Jan 14, 2019
This was created based on the following PR: dgrijalva#286 As per the JWT spec, the aud claim field can be either a single string value or an array of strings. jwt-go would completely drop array values as the StandardClaims struct's Audience field is a string value and the value is dropped upon deserialization.
This was referenced Oct 19, 2020
This was referenced Nov 30, 2020
|
What is the status of this PR? This appears to be a fix for a security issue that is affecting us downstream. |
|
so when is this PR going to be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the JWT spec, the aud claim field can be either a single string value or an array of strings.
jwt-go would completely drop array values as the StandardClaims struct's Audience field is a string value and the value is dropped upon deserialization.