This repository has been archived by the owner on May 21, 2022. It is now read-only.
Fix security issue with aud validation #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgrijalva can we get this merged? This is a vital security patch IMHO. |
|
Due to golang/go#33908 it is not possible to perform go get on a PR so its either:
|
|
For those following this PR please look at #428 where we are trying to get things back to a maintained state |
|
This has already been done in #286 I think. |
Aud validation on the JWT was being bypassed if a list of claims was presented
to the server. This commit checks if the aud claim is a list of strings, if not
it checks if its a single string, if not it will return invalid
Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Waterdrips
force-pushed
the
waterdrips-fix-cve
branch
from
6474ec9
to
614772a
Compare
|
applied the same patch as golang-jwt/jwt#12 as per #462 (comment) |
|
Hello there, do we know when/if this will be released. Thanks for the fix ! |
Please see repo golang-jwt/jwt where this project continues |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aud validation on the JWT was being bypassed if a list of claims was presented
to the server. This commit checks if the aud claim is a list of strings, if not
it checks if its a single string, if not it will return invalid
This fixes #422 #428
Signed-off-by: Alistair Hey alistair.hey@form3.tech