Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/timers): fix flakiness of httpConnAutoCloseDelayedOnUpgrade test #13017

Merged
merged 14 commits into from
Dec 7, 2021

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Dec 7, 2021

Closes #12944

@kt3k kt3k changed the title WIP fix flaky timer test fix(ext/timers): fix flakiness of httpConnAutoCloseDelayedOnUpgrade test Dec 7, 2021
@kt3k kt3k marked this pull request as ready for review December 7, 2021 14:50
@kt3k kt3k requested a review from bartlomieju as a code owner December 7, 2021 14:50
@kt3k
Copy link
Member Author

kt3k commented Dec 7, 2021

The first 5 runs show the test case is still flaky (362b0e1 failed with httpConnAutoCloseDelayedOnUpgrade)
The last 10 runs show the flakiness is fixed by this change.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into it.

@kt3k kt3k force-pushed the fix-timers-flaky-3 branch from 7691129 to 11ca89a Compare December 7, 2021 16:46
@kt3k kt3k merged commit 5c06368 into denoland:main Dec 7, 2021
@kt3k kt3k deleted the fix-timers-flaky-3 branch December 7, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

httpConnAutoCloseDelayedOnUpgrade and httpServerDeleteRequestHasBody are flaky
2 participants