Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/timers): fix flakiness of httpConnAutoCloseDelayedOnUpgrade test #13017

Merged
merged 14 commits into from
Dec 7, 2021
Merged

fix(ext/timers): fix flakiness of httpConnAutoCloseDelayedOnUpgrade test #13017

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
66c63df
rerun ci
kt3k Dec 7, 2021
362b0e1
rerun ci
kt3k Dec 7, 2021
d435827
rerun ci
kt3k Dec 7, 2021
6e506f7
rerun ci
kt3k Dec 7, 2021
77c1e20
rerun ci
kt3k Dec 7, 2021
497bd2d
test: fix flaky ws test
kt3k Dec 2, 2021
cb2716a
rerun ci
kt3k Dec 7, 2021
ee87292
rerun ci
kt3k Dec 7, 2021
a5a20ca
rerun ci
kt3k Dec 7, 2021
a243819
rerun ci
kt3k Dec 7, 2021
059ce77
rerun ci
kt3k Dec 7, 2021
fe11065
rerun ci
kt3k Dec 7, 2021
a412747
rerun ci
kt3k Dec 7, 2021
11ca89a
rerun ci
kt3k Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cli/tests/unit/http_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,12 +1055,16 @@ Deno.test(

const { socket, response } = Deno.upgradeWebSocket(event1.request);
socket.onmessage = (event) => socket.send(event.data);
const socketClosed = new Promise<void>((resolve) => {
socket.onclose = () => resolve();
});
event1.respondWith(response);

const event2 = await event2Promise;
assertStrictEquals(event2, null);

listener.close();
await socketClosed;
}

async function client() {
Expand Down