Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpConnAutoCloseDelayedOnUpgrade and httpServerDeleteRequestHasBody are flaky #12944

Closed
andreubotella opened this issue Nov 30, 2021 · 1 comment · Fixed by #13017
Closed
Labels
flaky a test is not reliable or determinstic

Comments

@andreubotella
Copy link
Contributor

https://github.com/denoland/deno/runs/4361438674?check_suite_focus=true#step:35:2107

These tests have pending async ops in commits for #12862. That PR changes the clamping of timers from 4ms to 0, which affects the delay before the ops sanitizer runs, but as pointed out by @lucacasonato in #12862 (comment), if the pending ops take longer than one event loop turn to resolve, that is a bug.

@bartlomieju bartlomieju added the flaky a test is not reliable or determinstic label Dec 1, 2021
@bnoordhuis
Copy link
Contributor

https://github.com/denoland/deno/runs/4443957712?check_suite_focus=true - now happening on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky a test is not reliable or determinstic
Projects
None yet
3 participants