Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contains ignore case in go to row #1291

Merged
merged 4 commits into from
May 17, 2023

Conversation

ethanalvizo
Copy link
Contributor

Closes #1274

@ethanalvizo ethanalvizo self-assigned this May 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ethanalvizo ethanalvizo requested a review from mofojed May 11, 2023 15:46
packages/iris-grid/src/GotoRow.tsx Show resolved Hide resolved
packages/iris-grid/src/IrisGrid.tsx Show resolved Hide resolved
packages/iris-grid/src/GotoRow.test.tsx Outdated Show resolved Hide resolved
@ethanalvizo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ethanalvizo
Copy link
Contributor Author

recheck

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1291 (c3ad3f1) into main (d304300) will decrease coverage by 0.35%.
The diff coverage is 20.00%.

❗ Current head c3ad3f1 differs from pull request most recent head a2273e0. Consider uploading reports for the commit a2273e0 to get more accurate results

@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
- Coverage   45.89%   45.54%   -0.35%     
==========================================
  Files         492      504      +12     
  Lines       34371    34827     +456     
  Branches     8566     8690     +124     
==========================================
+ Hits        15775    15863      +88     
- Misses      18545    18913     +368     
  Partials       51       51              
Flag Coverage Δ
unit 45.54% <20.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/IrisGrid.tsx 27.10% <0.00%> (+0.01%) ⬆️
packages/iris-grid/src/GotoRow.tsx 59.37% <100.00%> (+19.79%) ⬆️

... and 51 files with indirect coverage changes

mofojed
mofojed previously approved these changes May 12, 2023
packages/iris-grid/src/GotoRow.tsx Outdated Show resolved Hide resolved
packages/iris-grid/src/GotoRow.tsx Outdated Show resolved Hide resolved
packages/iris-grid/src/GotoRow.tsx Outdated Show resolved Hide resolved
@ethanalvizo ethanalvizo requested a review from mofojed May 16, 2023 20:36
@ethanalvizo ethanalvizo merged commit d67712e into deephaven:main May 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Contains Ignore Case option to Seek Row functionality
3 participants