Skip to content

Commit

Permalink
change aria-labels to readable strings
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanalvizo committed May 15, 2023
1 parent 90227c1 commit d4c2ad9
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions packages/iris-grid/src/GotoRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ function GotoRow({
}
}}
value={gotoValue}
aria-label="value-input"
aria-label="Value Input"
/>
</div>
);
Expand All @@ -180,7 +180,7 @@ function GotoRow({
defaultValue={gotoValue}
onChange={onGotoValueInputChanged}
onSubmit={handleGotoValueKeySubmit}
aria-label="value-input"
aria-label="Value Input"
/>
</div>
);
Expand Down Expand Up @@ -228,7 +228,7 @@ function GotoRow({
placeholder="value"
onChange={e => onGotoValueInputChanged(e.target.value)}
value={gotoValue}
aria-label="value-input"
aria-label="Value Input"
/>
</div>
</>
Expand All @@ -242,7 +242,7 @@ function GotoRow({
onGotoValueInputChanged(event.target.value);
}}
value={gotoValue}
aria-label="value-input"
aria-label="Value Input"
>
<option aria-label="null value" key="null" value="" />
<option key="true" value="true">
Expand All @@ -264,7 +264,7 @@ function GotoRow({
placeholder="value"
onChange={e => onGotoValueInputChanged(e.target.value)}
value={gotoValue}
aria-label="value-input"
aria-label="Value Input"
/>
</div>
);
Expand Down Expand Up @@ -331,17 +331,15 @@ function GotoRow({
</div>
{model.isSeekRowAvailable && (
<div className="goto-row-row">
<fieldset
<div
className={classNames('goto-row-wrapper', {
'is-inactive': isGotoRowActive,
})}
onClick={() => setIsGotoRowActive(false)}
onFocus={() => setIsGotoRowActive(false)}
role="group"
>
<div>
<legend className="goto-row-text">Go to value</legend>
</div>
<div className="goto-row-text">Go to value</div>
<div className="goto-row-input">
<select
className="custom-select"
Expand Down Expand Up @@ -385,7 +383,7 @@ function GotoRow({
{gotoValueError && (
<div className="text-danger">{gotoValueError}</div>
)}
</fieldset>
</div>
</div>
)}
</>
Expand Down

0 comments on commit d4c2ad9

Please sign in to comment.