Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contains Ignore Case option to Seek Row functionality #1274

Closed
mofojed opened this issue May 8, 2023 · 2 comments · Fixed by #1291
Closed

Add Contains Ignore Case option to Seek Row functionality #1274

mofojed opened this issue May 8, 2023 · 2 comments · Fixed by #1291
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mofojed
Copy link
Member

mofojed commented May 8, 2023

We currently have Seek Row functionality in grids for searching for text within a column. There are only a few options there, we should add the Contains Ignore Case option as well.

image

Context: https://illumon.slack.com/archives/CAUG7MC2D/p1683398883944149

@mofojed mofojed added enhancement New feature or request triage Issue requires triage good first issue Good for newcomers and removed triage Issue requires triage labels May 8, 2023
@dsmmcken
Copy link
Contributor

dsmmcken commented May 8, 2023

These should use human labels -- "Equals (ignore case)" or whatever we've done elsewhere.

@mofojed
Copy link
Member Author

mofojed commented May 9, 2023

@ethanalvizo you can create a table with a string column to test this feature. From our docs (https://deephaven.io/core/docs/reference/table-operations/create/stringCol/):

from deephaven import new_table
from deephaven.column import string_col

result = new_table([
    string_col("x", ["Deephaven", "DEEPHAVEN", "deephaven", "illumon", "ILLUMON"])
])

Then in the table that appears, open the table sidebar and click the "Go to" option to display the Go to feature:
image

ethanalvizo added a commit that referenced this issue May 17, 2023
Closes #1274

---------

Co-authored-by: Ethan Alvizo <ethanalvizo@Ethans-Laptop.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants