Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DH RadioGroup with Spectrum version #2020

Closed
bmingles opened this issue May 15, 2024 · 0 comments · Fixed by #2021
Closed

Replace DH RadioGroup with Spectrum version #2020

bmingles opened this issue May 15, 2024 · 0 comments · Fixed by #2021
Assignees
@bmingles
Labels
enhancement New feature or request
Milestone
May 2024

Comments

@bmingles
Copy link
Contributor

We want to replace our @deephaven/components RadioGroup component wit Spectrum's

  • Delete RadioGroup and RadioItem components
  • Re-export Spectrum RadioGroup and Radio compnents
  • Update all references to DH RadioGroup
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels May 15, 2024
@bmingles bmingles self-assigned this May 15, 2024
@bmingles bmingles mentioned this issue May 15, 2024
Closed
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Replaced RadioGroup with Spectrum's (deephaven#2020)
c0cd441
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Fixed RadioGroup layout (deephaven#2020)
145f96c
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Updated e2e snapshots (deephaven#2020)
d448acd
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Fixed input tests to be closer to original (deephaven#2020)
a396537
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Updated e2e tests (deephaven#2020)
b93a701
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Fixed aria warnings and deleted test (deephaven#2020)
05fa967
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Updated e2e snapshots (deephaven#2020)
0a1ecc5
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Added radio focus key color (deephaven#2020)
6b254f4
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 16, 2024
@bmingles
radio unselected focus color (deephaven#2020)
bac43ca
@bmingles bmingles linked a pull request May 16, 2024 that will close this issue
feat: Replaced RadioGroup with Spectrum's (#2020) #2021
Merged
@vbabich vbabich removed the triage Issue requires triage label May 21, 2024
@vbabich vbabich added this to the May 2024 milestone May 21, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 22, 2024
@bmingles
Addressed review comment and updated e2e (deephaven#2020)
b6e264c
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 22, 2024
@bmingles
Fixed orientation (deephaven#2020)
7c75d17
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 22, 2024
@bmingles
Updated e2e snapshots (deephaven#2020)
6875902
bmingles added a commit that referenced this issue May 22, 2024
@bmingles
feat: Replaced RadioGroup with Spectrum's (#2020) (#2021)
c9ac72d 
- Removed DH `RadioGroup` and `RadioItem` components
- Re-exported Spectrum `RadioGroup` and `Radio` components
- Updated references to use new version

Here's diffs of what the components look like after migrating to
Spectrum RadioGroup:

**FilterSetManager**
<img width="645" alt="image"
src="https://github.com/deephaven/web-client-ui/assets/1900643/7640bf22-2fa4-41b1-ae24-7939660c0424">

**ChartBuilder**
<img width="658" alt="image"
src="https://github.com/deephaven/web-client-ui/assets/1900643/fe91065b-92a6-4beb-9d5c-e7b0acff4e11">

**TableCsvExporter**
<img width="658" alt="image"
src="https://github.com/deephaven/web-client-ui/assets/1900643/0dadcf86-3567-4d5c-a164-45c923f06585">

**Aggregations**
<img width="656" alt="image"
src="https://github.com/deephaven/web-client-ui/assets/1900643/b6e89a38-9df6-492a-94fd-4f5296d3d4f1">

BREAKING CHANGE: `RadioGroup` has been replaced by Spectrum
`RadioGroup`. `RadioItem` has been replaced by Spectrum `Radio`
@mofojed mofojed mentioned this issue May 24, 2024
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue May 24, 2024
@github-actions @deephaven-internal
Update web version 0.79.0 (#5531)
4446605 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.79.0

# [0.79.0](deephaven/web-client-ui@v0.78.0...v0.79.0) (2024-05-24)


### Bug Fixes

* Replace shortid package with nanoid package ([#2025](deephaven/web-client-ui#2025)) ([30d9d3c](deephaven/web-client-ui@30d9d3c))
* Unedited markdown widgets not persisting ([#2019](deephaven/web-client-ui#2019)) ([c17f136](deephaven/web-client-ui@c17f136))


### Features

* e2e combined improvements ([#1998](deephaven/web-client-ui#1998)) ([99fc2f6](deephaven/web-client-ui@99fc2f6))
* re-export Spectrum ButtonGroup ([#2028](deephaven/web-client-ui#2028)) ([3115dd1](deephaven/web-client-ui@3115dd1))
* Replaced `RadioGroup` with Spectrum's ([#2020](deephaven/web-client-ui#2020)) ([#2021](deephaven/web-client-ui#2021)) ([c9ac72d](deephaven/web-client-ui@c9ac72d))


### BREAKING CHANGES

* `RadioGroup` has been replaced by Spectrum
`RadioGroup`. `RadioItem` has been replaced by Spectrum `Radio`
* Removed ButtonOld component, use Button instead.





Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 4, 2024
@bmingles
re-export Radio and RadioGroup prop types (deephaven#2020)
2ba9b9b
@bmingles bmingles mentioned this issue Jun 4, 2024
Merged
bmingles added a commit that referenced this issue Jun 4, 2024
@bmingles
fix: re-export Radio and RadioGroup prop types (#2055)
06b9767 
I missed some prop types on #2020
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 4, 2024
@bmingles
Exporting correct Radio prop types (deephaven#2020)
450a7e3
@bmingles bmingles mentioned this issue Jun 4, 2024
Merged
bmingles added a commit that referenced this issue Jun 4, 2024
@bmingles
fix: Exporting correct Radio prop types (#2058)
98be05a 
Looks like I exported the incorrect Radio component prop types in
previous PR. There are apparently extended ones for Spectrum.


https://github.com/adobe/react-spectrum/blob/7da3d384aa0c6bdc14449c4f138e963a094a7a38/packages/%40react-types/radio/src/index.d.ts#L58-L71

#2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

feat: Replaced RadioGroup with Spectrum's (#2020) bmingles/web-client-ui
2 participants
@bmingles @vbabich