-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replaced RadioGroup
with Spectrum's (#2020)
#2021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to clean up the example in the styleguide
errorMessage={ | ||
radioValue === '4' ? 'Invalid radio selected' : undefined | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't think you necessarily need a ternary here, as the error message is only shown when it's invalid anyway. But no matter.
errorMessage={ | |
radioValue === '4' ? 'Invalid radio selected' : undefined | |
} | |
errorMessage="Invalid radio selected" |
RadioGroup
andRadioItem
componentsRadioGroup
andRadio
componentsHere's diffs of what the components look like after migrating to Spectrum RadioGroup:
FilterSetManager
ChartBuilder
TableCsvExporter
Aggregations
BREAKING CHANGE:
RadioGroup
has been replaced by SpectrumRadioGroup
.RadioItem
has been replaced by SpectrumRadio