Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Form components compatible with Spectrum / dh.ui #1989

Closed
bmingles opened this issue May 6, 2024 · 1 comment
Closed

Make Form components compatible with Spectrum / dh.ui #1989

bmingles opened this issue May 6, 2024 · 1 comment
Assignees
@bmingles

Comments

@bmingles
Copy link
Contributor

bmingles commented May 6, 2024 •
edited
Loading

We have some form components in @deephaven/components that override names of Spectrum components. Some of these, such as ButtonGroup can probably be easily converted to Spectrum apis while others such as CheckBox will be more involved. We should convert ButtonGroup and any others that are "low hanging fruit" as part of this ticket and create new tickets for any others that are more involved.
@bmingles bmingles self-assigned this May 6, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 8, 2024
@bmingles
Added comments about Spectrum components not re-exported (deephaven#1989
e664f8b 
)
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 8, 2024
@bmingles
Added support to our ButtonOld for Spectrum ButtonGroup (deephaven#1989)
bc133db
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 8, 2024
@bmingles
comment (deephaven#1989)
639861d
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 9, 2024
@bmingles
Renamed ButtonGroup to SplitButtonGroup (deephaven#1989)
edba31a
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 9, 2024
@bmingles
Button useSlotProps (deephaven#1989)
7c663eb
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 9, 2024
@bmingles
re-export ButtonGroup (deephaven#1989)
5e69f6a
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 14, 2024
@bmingles
Added comments about Spectrum components not re-exported (deephaven#1989
b4247a5 
)
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 14, 2024
@bmingles
Added support to our ButtonOld for Spectrum ButtonGroup (deephaven#1989)
ac52890
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 14, 2024
@bmingles
comment (deephaven#1989)
ffa73f0
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 14, 2024
@bmingles
Renamed ButtonGroup to SplitButtonGroup (deephaven#1989)
aff98bb
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 14, 2024
@bmingles
Button useSlotProps (deephaven#1989)
f07656d
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 14, 2024
@bmingles
re-export ButtonGroup (deephaven#1989)
36b4bac
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 14, 2024
@bmingles
Renamed ButtonGroup to SplitButtonGroup (deephaven#1989)
13385ea
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 14, 2024
@bmingles
Updated comments (deephaven#1989)
04c017f
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 14, 2024
@bmingles
Comment (deephaven#1989)
0b4a2f0
@bmingles bmingles mentioned this issue May 14, 2024
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Added comments about Spectrum components not re-exported (deephaven#1989
1c88315 
)
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Renamed ButtonGroup to SplitButtonGroup (deephaven#1989)
2992435
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Updated comments (deephaven#1989)
ccf7dcd
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Comment (deephaven#1989)
55e9a71
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 15, 2024
@bmingles
Fixed bad rebase (deephaven#1989)
3b8c3bc
@bmingles
Copy link
Contributor Author

bmingles commented Jun 3, 2024

All of the subtasks are complete

@bmingles bmingles closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmingles