Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Checkbox component props to be closer to Spectrum apis #2018

Closed
bmingles opened this issue May 14, 2024 · 1 comment
Closed

Extend Checkbox component props to be closer to Spectrum apis #2018

bmingles opened this issue May 14, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
June 2024

Comments

@bmingles
Copy link
Contributor

We have our own Checkbox component in @deephaven/components. We aren't currently planning to replace this with Spectrum's Checkbox, but we should augment it to include more of Spectrum's apis.

https://react-spectrum.adobe.com/react-spectrum/Checkbox.html#props
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels May 14, 2024
@bmingles bmingles mentioned this issue May 14, 2024
Closed
@vbabich vbabich added this to the June 2024 milestone May 21, 2024
@vbabich vbabich removed the triage Issue requires triage label May 21, 2024
@bmingles
Copy link
Contributor Author

bmingles commented Jun 3, 2024

We decided to re-export Spectrum component instead: #2038

@bmingles bmingles closed this as completed Jun 3, 2024
@AkshatJawne AkshatJawne mentioned this issue Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
June 2024
Development

No branches or pull requests
2 participants
@bmingles @vbabich