Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logos missing in production build #1712

Closed
bmingles opened this issue Jan 8, 2024 · 0 comments · Fixed by #1713
Closed

Logos missing in production build #1712

bmingles opened this issue Jan 8, 2024 · 0 comments · Fixed by #1713
Assignees
@bmingles
Labels
bug Something isn't working web-client-ui

Comments

@bmingles
Copy link
Contributor

bmingles commented Jan 8, 2024

Description

Themed logos don't work in production deployment

Steps to reproduce

  • npm run build

Expected results

Logo should be present after build

Actual results

  • packages/components/theme/logos folder is not copied to dist where they are expected by Logo.css
  • npm run preview shows missing logoAdditional details and attachments

Versions

0.31.0-SNAPSHOT
@bmingles bmingles added bug Something isn't working triage Issue requires triage labels Jan 8, 2024
@bmingles bmingles self-assigned this Jan 8, 2024
@bmingles bmingles added web-client-ui and removed triage Issue requires triage labels Jan 8, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jan 8, 2024
@bmingles
Moved logos
10d4ae0 
deephaven#1712
@bmingles bmingles mentioned this issue Jan 8, 2024
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jan 8, 2024
@bmingles
Added logos to files
eee4220 
deephaven#1712
bmingles added a commit that referenced this issue Jan 9, 2024
@bmingles
fix: Moved logos so they show in production build (#1713)
a3bea73 
Moved logos so they show in production build

fixes #1712

**Test Plan**
`npm run build`
`npm run preview`

Open DH, logo should show up for both dark and light themes
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Jan 17, 2024
@github-actions @deephaven-internal
Update web version 0.59.0 (#5044)
b99c015 
# [0.59.0](deephaven/web-client-ui@v0.58.0...v0.59.0) (2024-01-17)


### Bug Fixes

* GoToRow timestamp fails when selected row is out of view ([#1717](deephaven/web-client-ui#1717)) ([9ddc973](deephaven/web-client-ui@9ddc973)), closes [#1561](deephaven/web-client-ui#1561)
* Interface for IrisGridTableModelTemplate.backgroundColorForCell ([#1699](deephaven/web-client-ui#1699)) ([73e1837](deephaven/web-client-ui@73e1837)), closes [#1697](deephaven/web-client-ui#1697)
* Moved logos so they show in production build ([#1713](deephaven/web-client-ui#1713)) ([a3bea73](deephaven/web-client-ui@a3bea73)), closes [#1712](deephaven/web-client-ui#1712)
* re-colorize command codeblocks when theme changes ([#1731](deephaven/web-client-ui#1731)) ([b1e42f5](deephaven/web-client-ui@b1e42f5))
* TimeInput not triggering onChange on incomplete values ([#1711](deephaven/web-client-ui#1711)) ([6894d96](deephaven/web-client-ui@6894d96)), closes [#1710](deephaven/web-client-ui#1710)


### Features

* Action button tooltips ([#1706](deephaven/web-client-ui#1706)) ([bff6bf9](deephaven/web-client-ui@bff6bf9)), closes [#1705](deephaven/web-client-ui#1705)
* Add support for useDeferredApi ([#1725](deephaven/web-client-ui#1725)) ([51ebe1b](deephaven/web-client-ui@51ebe1b))
* Improved preload variable handling ([#1723](deephaven/web-client-ui#1723)) ([ed41c42](deephaven/web-client-ui@ed41c42)), closes [#1695](deephaven/web-client-ui#1695) [#1679](deephaven/web-client-ui#1679)
* NavTabList component ([#1698](deephaven/web-client-ui#1698)) ([96641fb](deephaven/web-client-ui@96641fb))
* Reject promise immediately if var not found ([#1718](deephaven/web-client-ui#1718)) ([43d40bd](deephaven/web-client-ui@43d40bd)), closes [#1701](deephaven/web-client-ui#1701)
* theming tweaks ([#1727](deephaven/web-client-ui#1727)) ([f919a7e](deephaven/web-client-ui@f919a7e))


### BREAKING CHANGES

* - Subclasses of IrisGridTableModelTemplate or it's subclasses that use
backgroundColorForCell may need to update their signature to accept the
theme if they are calling the superclass


Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working web-client-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Moved logos so they show in production build bmingles/web-client-ui
1 participant
@bmingles