Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Interface for IrisGridTableModelTemplate.backgroundColorForCell #1699

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 19, 2023

BREAKING CHANGE:

  • Subclasses of IrisGridTableModelTemplate or it's subclasses that use backgroundColorForCell may need to update their signature to accept the theme if they are calling the superclass

- The implementation for IrisGridTableModelTemplate.backgroundColorForCell did not accept a theme, even though GridModel.backgroundColorForCell does
- This caused issues with classes that extended IrisGridTableModelTemplate or it's subclasses like IrisGridTableModel, as the could not override this method to correctly accept the theme parameter

BREAKING CHANGE:
- Subclasses of IrisGridTableModelTemplate or it's subclasses that use backgroundColorForCell may need to update their signature to accept the theme if they are calling the superclass
@mofojed mofojed requested a review from vbabich December 19, 2023 23:25
@mofojed mofojed self-assigned this Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73e0b65) 46.67% compared to head (89ae4f3) 46.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1699   +/-   ##
=======================================
  Coverage   46.67%   46.67%           
=======================================
  Files         606      606           
  Lines       36873    36873           
  Branches     9267     9267           
=======================================
  Hits        17211    17211           
  Misses      19610    19610           
  Partials       52       52           
Flag Coverage Δ
unit 46.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 73e1837 into deephaven:main Jan 4, 2024
6 checks passed
@mofojed mofojed deleted the 1697-fix-iris-grid-types branch January 4, 2024 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants