Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Interface for IrisGridTableModelTemplate.backgroundColorForCell #1699

Merged
merged 1 commit into from
Jan 4, 2024

Commits on Dec 19, 2023

  1. fix: Interface for IrisGridTableModelTemplate.backgroundColorForCell

    - The implementation for IrisGridTableModelTemplate.backgroundColorForCell did not accept a theme, even though GridModel.backgroundColorForCell does
    - This caused issues with classes that extended IrisGridTableModelTemplate or it's subclasses like IrisGridTableModel, as the could not override this method to correctly accept the theme parameter
    
    BREAKING CHANGE:
    - Subclasses of IrisGridTableModelTemplate or it's subclasses that use backgroundColorForCell may need to update their signature to accept the theme if they are calling the superclass
    mofojed committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    89ae4f3 View commit details
    Browse the repository at this point in the history