fix: Moved logos so they show in production build #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1713 +/- ##
=======================================
Coverage 46.44% 46.44%
=======================================
Files 611 611
Lines 37204 37204
Branches 9363 9363
=======================================
Hits 17279 17279
Misses 19871 19871
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
requested changes
Jan 8, 2024
There was a problem hiding this comment.
This won't work when you actually publish the package. The outputted result in dist/theme/Logo.css is:
:root{--dh-logo-dark-img: url("../../logos/community-wordmark-dark.svg");--dh-logo-light-img: url("../../logos/community-wordmark-light.svg")}.dh-logo{--dh-logo-width: 230;--dh-logo-height: 40;aspect-ratio:var(--dh-logo-width)/var(--dh-logo-height);max-height:100%;max-width:100%;height:calc(var(--dh-logo-height)*1px);background-image:var(--dh-logo-img);background-repeat:no-repeat;background-position:left center}/*# sourceMappingURL=Logo.css.map */
Which is finding the logo from that path. But the logo dir is not included in the files attributes of package.json, and won't be in the resulting package, so this will still fail after publishing.
|
@mofojed I fixed the files config. Tested via docker compose build of deephaven-core pointed to alpha |
mofojed
approved these changes
Jan 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved logos so they show in production build
fixes #1712
Test Plan
npm run buildnpm run previewOpen DH, logo should show up for both dark and light themes