Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticking tables scrolling back to bottom when not stuck to bottom #1615

Closed
mattrunyon opened this issue Nov 2, 2023 · 0 comments · Fixed by #1616
Closed

Ticking tables scrolling back to bottom when not stuck to bottom #1615

mattrunyon opened this issue Nov 2, 2023 · 0 comments · Fixed by #1616
Assignees
@mattrunyon
Labels
bug Something isn't working

Comments

@mattrunyon
Copy link
Collaborator

Description

Broken by #1579. The stickyOptions is not correct. Scrolling up results in false and no update of isStuckToBottom. Moving the table via the scroll handle also does not update isStuckToBottom.

Steps to reproduce

  1. Create a ticking table
  2. Scroll (with mouse wheel) to the bottom. Can drag the scroll thumb to the bottom then wheel up and down to do this
  3. Scroll up or use the scroll thumb to move up

Expected results

Table stays where you scrolled

Actual results

On the next tick, the table will go back to the bottom. isStuckToBottom is not properly updated

Versions

  • Web UI Version: 0.52.0
@mattrunyon mattrunyon added bug Something isn't working triage Issue requires triage labels Nov 2, 2023
@mattrunyon mattrunyon changed the title Grid stickToBottom is broken Ticking tables scrolling back to bottom when not stuck to bottom Nov 2, 2023
This was referenced Nov 2, 2023
Merged
Closed
@mattrunyon mattrunyon self-assigned this Nov 2, 2023
@mattrunyon mattrunyon removed the triage Issue requires triage label Nov 2, 2023
mattrunyon added a commit that referenced this issue Nov 2, 2023
@mattrunyon
revert: "fix: stuck to bottom on filter clear" (#1616)
806a6b6 
Reverts #1579

Fixes #1615
@mofojed mofojed mentioned this issue Nov 3, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Nov 3, 2023
@github-actions @deephaven-internal
Update web version 0.53.0 (#4770)
77b25b0 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.53.0

# [0.53.0](deephaven/web-client-ui@v0.52.0...v0.53.0) (2023-11-03)


### Bug Fixes

* DH-15864: Scroll position StuckToBottom shouldn't trigger sharing dot ([#1617](deephaven/web-client-ui#1617)) ([3d4499b](deephaven/web-client-ui@3d4499b))
* Panel focus throwing an exception ([#1609](deephaven/web-client-ui#1609)) ([9e8b7ae](deephaven/web-client-ui@9e8b7ae))
* Plugins were re-registering on every re-render ([#1613](deephaven/web-client-ui#1613)) ([5977389](deephaven/web-client-ui@5977389))


### Features

* Add support for multi-partition parquet:kv tables ([#1580](deephaven/web-client-ui#1580)) ([d92c91e](deephaven/web-client-ui@d92c91e)), closes [#1143](deephaven/web-client-ui#1143) [#1438](deephaven/web-client-ui#1438)
* Babel Plugin - Mock css imports ([#1607](deephaven/web-client-ui#1607)) ([787c542](deephaven/web-client-ui@787c542)), closes [#1606](deephaven/web-client-ui#1606)
* Convert DashboardPlugins to WidgetPlugins ([#1598](deephaven/web-client-ui#1598)) ([a260842](deephaven/web-client-ui@a260842)), closes [#1573](deephaven/web-client-ui#1573)


### Reverts

* "fix: stuck to bottom on filter clear" ([#1616](deephaven/web-client-ui#1616)) ([806a6b6](deephaven/web-client-ui@806a6b6)), closes [deephaven/web-client-ui#1579](deephaven/web-client-ui#1579) [#1615](deephaven/web-client-ui#1615)

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrunyon mattrunyon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ticking tables scrolling back to bottom when not stuck to bottom deephaven/web-client-ui
1 participant
@mattrunyon