Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the new Filter class to support the new where methods #1613

Closed
jmao-denver opened this issue Nov 30, 2021 · 2 comments
Closed

Wrap the new Filter class to support the new where methods #1613

jmao-denver opened this issue Nov 30, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@jmao-denver
Copy link
Contributor

The db-module-refactor project has improved the table filter ops. This potentially requires that the new hand-crafted Python package to wrap the Filter interface.

@jmao-denver jmao-denver added the bug Something isn't working label Nov 30, 2021
@jmao-denver jmao-denver added this to the Dec 2021 milestone Nov 30, 2021
@jmao-denver jmao-denver self-assigned this Nov 30, 2021
@jmao-denver
Copy link
Contributor Author

jmao-denver commented Dec 3, 2021

Ryan:

We want to dump where_one_of
and tell people to use structured filter expressions if they have complex things to express

FilterAnd.of(FilterOr.of(Filter.of("true"), Filter.of("false")), Filter.of("column"))

Jianfeng:

so the wrapping should solve the ugliness of the above expression?

Ryan:

Or just make it do-able from Python.
I'm sure the wrapper can be more like "and(or(True, False), column))"

@pete-petey pete-petey modified the milestones: Dec 2021, Jan 2022 Dec 29, 2021
@pete-petey pete-petey modified the milestones: Jan 2022, April 2022 Apr 16, 2022
@jmao-denver
Copy link
Contributor Author

closed by #2336

mofojed pushed a commit that referenced this issue Nov 3, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.53.0

# [0.53.0](deephaven/web-client-ui@v0.52.0...v0.53.0) (2023-11-03)


### Bug Fixes

* DH-15864: Scroll position StuckToBottom shouldn't trigger sharing dot ([#1617](deephaven/web-client-ui#1617)) ([3d4499b](deephaven/web-client-ui@3d4499b))
* Panel focus throwing an exception ([#1609](deephaven/web-client-ui#1609)) ([9e8b7ae](deephaven/web-client-ui@9e8b7ae))
* Plugins were re-registering on every re-render ([#1613](deephaven/web-client-ui#1613)) ([5977389](deephaven/web-client-ui@5977389))


### Features

* Add support for multi-partition parquet:kv tables ([#1580](deephaven/web-client-ui#1580)) ([d92c91e](deephaven/web-client-ui@d92c91e)), closes [#1143](deephaven/web-client-ui#1143) [#1438](deephaven/web-client-ui#1438)
* Babel Plugin - Mock css imports ([#1607](deephaven/web-client-ui#1607)) ([787c542](deephaven/web-client-ui@787c542)), closes [#1606](deephaven/web-client-ui#1606)
* Convert DashboardPlugins to WidgetPlugins ([#1598](deephaven/web-client-ui#1598)) ([a260842](deephaven/web-client-ui@a260842)), closes [#1573](deephaven/web-client-ui#1573)


### Reverts

* "fix: stuck to bottom on filter clear" ([#1616](deephaven/web-client-ui#1616)) ([806a6b6](deephaven/web-client-ui@806a6b6)), closes [deephaven/web-client-ui#1579](deephaven/web-client-ui#1579) [#1615](deephaven/web-client-ui#1615)

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants