Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks are empty after Docker container restarts #1534

Closed
jjbrosnan opened this issue Sep 21, 2023 · 3 comments · Fixed by #1535 or deephaven/deephaven-core#4559
Closed

Notebooks are empty after Docker container restarts #1534

jjbrosnan opened this issue Sep 21, 2023 · 3 comments · Fixed by #1535 or deephaven/deephaven-core#4559
Assignees
Labels
bug Something isn't working

Comments

@jjbrosnan
Copy link

Description

In the last few days, I've had a few instances where I exit and restart my Docker container, only to find the notebook I was working on empty. I only saw it happen for notebooks not in a folder, though I didn't test it with notebooks in folders.

Steps to reproduce

Create a notebook, write a simple query, save it, and reload the Docker container.

Expected results

The notebook to appear as I was working on it before restarting my container.

Actual results

The notebook development panel is empty, despite having text in it previously.

Additional details and attachments

Versions

  • Engine Version: 0.28.1
  • Web UI Version: ...
  • Java Version: ...
  • Barrage Version: ...
  • OS: OS X
  • Browser: Chrome
  • Docker: 20.10.13
@jjbrosnan jjbrosnan added bug Something isn't working triage Issue requires triage labels Sep 21, 2023
@mattrunyon
Copy link
Collaborator

mattrunyon commented Sep 21, 2023

This seems to only be an issue for a notebook that was created and saved, but never closed after it was created. Current workaround would be to re-open the notebook from the file explorer and it should be good from that point forward.

Also appears you do not need to restart the server, just refresh the page in this case.

The issue is the fileMetadata doesn't get updated for the panel which makes the panel not rehydrate properly on reload. The first panel in this image was created then saved. Page was reloaded and then the 2nd panel was opened by opening the notebook from file explorer.

image

If there are any cases of the notebook still being empty when re-opened from the file explorer, then we'll need more specifics on how to reproduce.

@mattrunyon
Copy link
Collaborator

mattrunyon commented Sep 21, 2023

Confirmed works in DHC 0.27.0 (web UI 0.45.1), but not 0.28.0 (web UI 0.47.0). Also test DHC 0.27.0 w/ a newer web UI and the bug exists there, so seems to be a web UI issue, not core

Looks like it broke somewhere between web UI 0.46.0 and 0.46.1

@mattrunyon
Copy link
Collaborator

Broken by #1451

@mattrunyon mattrunyon self-assigned this Sep 22, 2023
@mattrunyon mattrunyon removed the triage Issue requires triage label Sep 22, 2023
@mattrunyon mattrunyon added this to the September 2023 milestone Sep 22, 2023
mattrunyon added a commit that referenced this issue Sep 22, 2023
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Sep 27, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.49.1

### Bug Fixes

* Copy did not work from embedded iframes ([#1528](deephaven/web-client-ui#1528)) ([3549a33](deephaven/web-client-ui@3549a33)), closes [#1527](deephaven/web-client-ui#1527)
* Dehydration of class components ([#1535](deephaven/web-client-ui#1535)) ([3e834de](deephaven/web-client-ui@3e834de)), closes [#1534](deephaven/web-client-ui#1534)
* inconsistent drag for webkit ([#1518](deephaven/web-client-ui#1518)) ([cd5408c](deephaven/web-client-ui@cd5408c)), closes [#1360](deephaven/web-client-ui#1360)
* Render tables partitioned by non-string columns ([#1533](deephaven/web-client-ui#1533)) ([585b2ff](deephaven/web-client-ui@585b2ff)), closes [#1441](deephaven/web-client-ui#1441)
* Right clicking with a custom context menu open should open another context menu ([#1526](deephaven/web-client-ui#1526)) ([bd08e1f](deephaven/web-client-ui@bd08e1f)), closes [#1525](deephaven/web-client-ui#1525)

# [0.49.0](deephaven/web-client-ui@v0.48.0...v0.49.0) (2023-09-15)


### Bug Fixes

* Plugin peer dependencies do not get versions from lerna ([#1517](deephaven/web-client-ui#1517)) ([322f6ff](deephaven/web-client-ui@322f6ff))
* Table overflow button has lower priority than grid tokens ([#1510](deephaven/web-client-ui#1510)) ([32e6d20](deephaven/web-client-ui@32e6d20)), closes [#1480](deephaven/web-client-ui#1480)


### Code Refactoring

* Improve table saver to always use the correct service worker ([#1515](deephaven/web-client-ui#1515)) ([2488e52](deephaven/web-client-ui@2488e52)), closes [#766](deephaven/web-client-ui#766)


### Features

* Update go to row panel's row number with cursorRow ([#1508](deephaven/web-client-ui#1508)) ([23ab5cc](deephaven/web-client-ui@23ab5cc)), closes [#1406](deephaven/web-client-ui#1406)


### BREAKING CHANGES

* `TableSaver` now expects the service worker to send it
a complete URL for download instead of just a file name. DHE will need
to adjust its `serviceWorker.js` to incorporate the same changes from
this PR.


Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants