Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default workingDir for tests #1528

Closed
devinrsmith opened this issue Nov 4, 2021 · 0 comments · Fixed by #1530
Closed

Use default workingDir for tests #1528

devinrsmith opened this issue Nov 4, 2021 · 0 comments · Fixed by #1530
Assignees
Milestone

Comments

@devinrsmith
Copy link
Member

We've been unable to upload JVM err logs due to the upload action being unable to find the files.

The GH working directory logs:

Working directory is '/home/runner/work/deephaven-core/deephaven-core'

SIGSEGV logs:

# An error report file with more information is saved as:
# /home/runner/work/deephaven-core/hs_err_pid9554.log

Turns out we are settings the workingDir for tests as the parent of the root dir; instead of leaving it as the project dir:

    p.tasks.withType(Test).all { Test t -> t.with {
        workingDir = "$rootDir/.."

This is likely due to historical concerns where we were checking out multiple repositories.

We should go back to the standard working directories in an effort to reduce complexity, as well as allowing the uploader action to find the JVM err logs against its default working directory.

@devinrsmith devinrsmith added this to the Nov 2021 milestone Nov 4, 2021
@devinrsmith devinrsmith self-assigned this Nov 4, 2021
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Nov 4, 2021
devinrsmith added a commit that referenced this issue Nov 4, 2021
mofojed pushed a commit that referenced this issue Sep 27, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.49.1

### Bug Fixes

* Copy did not work from embedded iframes ([#1528](deephaven/web-client-ui#1528)) ([3549a33](deephaven/web-client-ui@3549a33)), closes [#1527](deephaven/web-client-ui#1527)
* Dehydration of class components ([#1535](deephaven/web-client-ui#1535)) ([3e834de](deephaven/web-client-ui@3e834de)), closes [#1534](deephaven/web-client-ui#1534)
* inconsistent drag for webkit ([#1518](deephaven/web-client-ui#1518)) ([cd5408c](deephaven/web-client-ui@cd5408c)), closes [#1360](deephaven/web-client-ui#1360)
* Render tables partitioned by non-string columns ([#1533](deephaven/web-client-ui#1533)) ([585b2ff](deephaven/web-client-ui@585b2ff)), closes [#1441](deephaven/web-client-ui#1441)
* Right clicking with a custom context menu open should open another context menu ([#1526](deephaven/web-client-ui#1526)) ([bd08e1f](deephaven/web-client-ui@bd08e1f)), closes [#1525](deephaven/web-client-ui#1525)

# [0.49.0](deephaven/web-client-ui@v0.48.0...v0.49.0) (2023-09-15)


### Bug Fixes

* Plugin peer dependencies do not get versions from lerna ([#1517](deephaven/web-client-ui#1517)) ([322f6ff](deephaven/web-client-ui@322f6ff))
* Table overflow button has lower priority than grid tokens ([#1510](deephaven/web-client-ui#1510)) ([32e6d20](deephaven/web-client-ui@32e6d20)), closes [#1480](deephaven/web-client-ui#1480)


### Code Refactoring

* Improve table saver to always use the correct service worker ([#1515](deephaven/web-client-ui#1515)) ([2488e52](deephaven/web-client-ui@2488e52)), closes [#766](deephaven/web-client-ui#766)


### Features

* Update go to row panel's row number with cursorRow ([#1508](deephaven/web-client-ui#1508)) ([23ab5cc](deephaven/web-client-ui@23ab5cc)), closes [#1406](deephaven/web-client-ui#1406)


### BREAKING CHANGES

* `TableSaver` now expects the service worker to send it
a complete URL for download instead of just a file name. DHE will need
to adjust its `serviceWorker.js` to incorporate the same changes from
this PR.


Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant