Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After updating to new version, the web UI is blank, needs cache cleared to fix #766

Closed
mofojed opened this issue Jun 21, 2021 · 1 comment · Fixed by #823
Closed

After updating to new version, the web UI is blank, needs cache cleared to fix #766

mofojed opened this issue Jun 21, 2021 · 1 comment · Fixed by #823
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Jun 21, 2021

Description
Sometimes after an update, the web UI is blank. You need to clear the cache to fix it

Steps to reproduce

  1. Start on an older version. Start up the stack and open the web UI (http://localhost:10000)
  2. Shutdown the stack, then git pull to the latest version
  3. Start up the stack and open the web UI

Expected results
3. The Web UI appears

Actual results
3. A blank screen appears

After clearing the browser cache or doing a hard refresh, the web UI appears correctly

@mofojed mofojed added bug Something isn't working triage labels Jun 21, 2021
@mofojed mofojed added this to the June 2021 milestone Jun 21, 2021
@mofojed mofojed self-assigned this Jun 21, 2021
@mofojed mofojed removed the triage label Jul 6, 2021
@mofojed
Copy link
Member Author

mofojed commented Jul 6, 2021

It looks like index.html is getting cached by nginx incorrectly. It is generating the tag based on the modified date and the content length: https://github.com/nginx/nginx/blob/41a241b3ef74dbbe3d82ab2ebbe682919e4a0b90/src/http/ngx_http_core_module.c#L1698

However, the modified date for each pack downloaded from npm is always the same (Oct 26, 1985), so the resulting etag is the same. npm does this intentionally as per this commit: npm/npm@58d2aa5#diff-fe919d90e71d3a699df92b186fdbee6b

Either we need to have that modified date updated when extracting the zip contents, or disable caching entirely on index.html (chunks should still be cached).

mofojed pushed a commit that referenced this issue Sep 27, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.49.1

### Bug Fixes

* Copy did not work from embedded iframes ([#1528](deephaven/web-client-ui#1528)) ([3549a33](deephaven/web-client-ui@3549a33)), closes [#1527](deephaven/web-client-ui#1527)
* Dehydration of class components ([#1535](deephaven/web-client-ui#1535)) ([3e834de](deephaven/web-client-ui@3e834de)), closes [#1534](deephaven/web-client-ui#1534)
* inconsistent drag for webkit ([#1518](deephaven/web-client-ui#1518)) ([cd5408c](deephaven/web-client-ui@cd5408c)), closes [#1360](deephaven/web-client-ui#1360)
* Render tables partitioned by non-string columns ([#1533](deephaven/web-client-ui#1533)) ([585b2ff](deephaven/web-client-ui@585b2ff)), closes [#1441](deephaven/web-client-ui#1441)
* Right clicking with a custom context menu open should open another context menu ([#1526](deephaven/web-client-ui#1526)) ([bd08e1f](deephaven/web-client-ui@bd08e1f)), closes [#1525](deephaven/web-client-ui#1525)

# [0.49.0](deephaven/web-client-ui@v0.48.0...v0.49.0) (2023-09-15)


### Bug Fixes

* Plugin peer dependencies do not get versions from lerna ([#1517](deephaven/web-client-ui#1517)) ([322f6ff](deephaven/web-client-ui@322f6ff))
* Table overflow button has lower priority than grid tokens ([#1510](deephaven/web-client-ui#1510)) ([32e6d20](deephaven/web-client-ui@32e6d20)), closes [#1480](deephaven/web-client-ui#1480)


### Code Refactoring

* Improve table saver to always use the correct service worker ([#1515](deephaven/web-client-ui#1515)) ([2488e52](deephaven/web-client-ui@2488e52)), closes [#766](deephaven/web-client-ui#766)


### Features

* Update go to row panel's row number with cursorRow ([#1508](deephaven/web-client-ui#1508)) ([23ab5cc](deephaven/web-client-ui@23ab5cc)), closes [#1406](deephaven/web-client-ui#1406)


### BREAKING CHANGES

* `TableSaver` now expects the service worker to send it
a complete URL for download instead of just a file name. DHE will need
to adjust its `serviceWorker.js` to incorporate the same changes from
this PR.


Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant