Copy/Rename/Delete are missing from notebook menu options #1359
Comments
georgecwan
added a commit
that referenced
this issue
Sep 28, 2023
* Adds options to make a copy of, rename, or delete the file currently being viewed in the notebook panel * Resolves #1359 #### Testing Instructions: * Open any file create a new file * Navigate to the overflow menu in the top right of the notebook panel * The "copy file" option should create a copy of the currently open file with all of its contents copied over * The created copy should not appear in the file explorer until a save operation is done on it * The "rename file" option should cause the file to appear in the file explorer with the same contents and specified name * If the file was saved under a different name before, the old file should be deleted * If the file was never saved before, this operation will be identical to a save * The "delete file" option should close the file that the notebook panel is currently displaying. * If the file has been saved before, the saved file should be deleted and no longer in the file explorer * If the file was never saved before, this operation will be identical to closing the file and discarding any changes --------- Co-authored-by: georgecwan <georgecwan@users.noreply.github.com>
mofojed
pushed a commit
that referenced
this issue
Oct 13, 2023
* Previously, duplicating a notebook file and then trying to delete it without saving it first will cause an error to occur * Added a `fileExists` function to `FileUtils` to handle this check * Added a `getUniqueCopyFileName` function to `FileUtils` * Behaviour of copying a file from `NotebookPanel` changed from opening an unsaved copy of the file to duplicating the file in `FileStorage` first * Related to #1359 #### Testing Instructions: * Open a file in the notebook panel * Copy the opened file by using the 'Copy File' option in the overflow menu * Delete the file by using the overflow menu (No error should occur) * Repeat the same steps but copy the file by right clicking the file in the file explorer * Delete the copied file again, this time it should also disappear from the file explorer --------- Co-authored-by: georgecwan <georgecwan@users.noreply.github.com>
mofojed
pushed a commit
to deephaven/deephaven-core
that referenced
this issue
Oct 24, 2023
# [0.50.0](deephaven/web-client-ui@v0.49.1...v0.50.0) (2023-10-13) ### Bug Fixes * Change display of rollup key columns from null to empty string ([#1563](deephaven/web-client-ui#1563)) ([327bcb6](deephaven/web-client-ui@327bcb6)), closes [#1483](deephaven/web-client-ui#1483) * Disabled failing e2e test ([#1554](deephaven/web-client-ui#1554)) ([49723ec](deephaven/web-client-ui@49723ec)), closes [#1553](deephaven/web-client-ui#1553) * Formatting Rule Doesn't use default set by user ([#1547](deephaven/web-client-ui#1547)) ([ce51229](deephaven/web-client-ui@ce51229)) * Handle deletion of unsaved copied file in NotebookPanel ([#1557](deephaven/web-client-ui#1557)) ([4021aac](deephaven/web-client-ui@4021aac)), closes [#1359](deephaven/web-client-ui#1359) * Prompt for resetting layout ([#1552](deephaven/web-client-ui#1552)) ([a273e64](deephaven/web-client-ui@a273e64)), closes [#1250](deephaven/web-client-ui#1250) * CSS based loading spinner (#1532) ([f06fbb0](deephaven/web-client-ui@f06fbb0)), closes [#1532](deephaven/web-client-ui#1532) [#1531](deephaven/web-client-ui#1531) ### Features * Add copy/rename/delete options to notebook overflow menu ([#1551](deephaven/web-client-ui#1551)) ([4441109](deephaven/web-client-ui@4441109)), closes [#1359](deephaven/web-client-ui#1359) * data bar render from API ([#1415](deephaven/web-client-ui#1415)) ([ee7d1c1](deephaven/web-client-ui@ee7d1c1)), closes [#0000](https://github.com/deephaven/web-client-ui/issues/0000) [#FF0000](https://github.com/deephaven/web-client-ui/issues/FF0000) [#FFFF00](https://github.com/deephaven/web-client-ui/issues/FFFF00) [#FFFF00](https://github.com/deephaven/web-client-ui/issues/FFFF00) [#00FF00](https://github.com/deephaven/web-client-ui/issues/00FF00) * Monaco theming ([#1560](deephaven/web-client-ui#1560)) ([4eda17c](deephaven/web-client-ui@4eda17c)), closes [#1542](deephaven/web-client-ui#1542) * Theme Plugin Loading ([#1524](deephaven/web-client-ui#1524)) ([a9541b1](deephaven/web-client-ui@a9541b1)), closes [#1a171](https://github.com/deephaven/web-client-ui/issues/1a171) [#4c7](https://github.com/deephaven/web-client-ui/issues/4c7) [#1a171](https://github.com/deephaven/web-client-ui/issues/1a171) [#4c7](https://github.com/deephaven/web-client-ui/issues/4c7) [#4c7](https://github.com/deephaven/web-client-ui/issues/4c7) [#1530](deephaven/web-client-ui#1530) ### BREAKING CHANGES * Theme variables have to be present on body to avoid Monaco init failing * Inline LoadingSpinner instances will need to be decorated with `className="loading-spinner-vertical-align"` for vertical alignment to work as before Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enterprise notebooks expose Copy/Rename/Delete on the notebook overflow menu dropdown, these options are missing in community.
Versions
Engine Version: 0.26.0
Web UI Version: 0.40.4
Java Version: 17.0.7
Barrage Version: 0.5.0
The text was updated successfully, but these errors were encountered: