Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add copy/rename/delete options to notebook overflow menu #1551

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

georgecwan
Copy link
Contributor

@georgecwan georgecwan commented Sep 27, 2023

Testing Instructions:

  • Open any file create a new file
  • Navigate to the overflow menu in the top right of the notebook panel
  • The "copy file" option should create a copy of the currently open file with all of its contents copied over
    • The created copy should not appear in the file explorer until a save operation is done on it
  • The "rename file" option should cause the file to appear in the file explorer with the same contents and specified name
    • If the file was saved under a different name before, the old file should be deleted
    • If the file was never saved before, this operation will be identical to a save
  • The "delete file" option should close the file that the notebook panel is currently displaying.
    • If the file has been saved before, the saved file should be deleted and no longer in the file explorer
    • If the file was never saved before, this operation will be identical to closing the file and discarding any changes

@georgecwan georgecwan self-assigned this Sep 27, 2023
@georgecwan georgecwan changed the title Add copy/rename/delete options to notebook overflow menu feat: Add copy/rename/delete options to notebook overflow menu Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f06fbb0) 46.42% compared to head (e56e580) 46.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1551      +/-   ##
==========================================
- Coverage   46.42%   46.39%   -0.03%     
==========================================
  Files         564      564              
  Lines       35775    35795      +20     
  Branches     8950     8953       +3     
==========================================
  Hits        16607    16607              
- Misses      19118    19138      +20     
  Partials       50       50              
Flag Coverage Δ
unit 46.39% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ashboard-core-plugins/src/panels/NotebookPanel.tsx 1.51% <0.00%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mofojed
mofojed previously approved these changes Sep 28, 2023
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! For future PRs I'd like details on what testing you did.

@georgecwan georgecwan merged commit 4441109 into deephaven:main Sep 28, 2023
7 checks passed
@georgecwan georgecwan deleted the 1359-overflow-menu-options branch September 28, 2023 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy/Rename/Delete are missing from notebook menu options
2 participants