Extract deephaven/runtime-base #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
reviewed
Nov 12, 2021
| rm -rf /var/lib/apt/lists/*; \ | ||
| python3 -m pip install -q --no-cache-dir --upgrade pip; \ | ||
| python3 -m pip install -q --no-cache-dir --upgrade setuptools; \ | ||
| python3 -m pip install -q --no-cache-dir --upgrade wheel |
There was a problem hiding this comment.
where possible, version these pip/apt-get packages in this file
There was a problem hiding this comment.
I've got a new structure for requirements.txt, let me know what you think.
| evaluationDependsOn ':docker-java-and-python' | ||
| evaluationDependsOn ':deephaven-jpy' | ||
| evaluationDependsOn ':deephaven-wheel' | ||
| evaluationDependsOn ':deephaven2-wheel' |
There was a problem hiding this comment.
eesh i wish we had dependencies instead of this stringy goo you hope you never forget...
There was a problem hiding this comment.
I think the good news is that the gradle build will just fail to work if an evaluationDependsOn is missing. That said, it's not necessarily consistently failing - but hopefully it's obvious enough to us doing "things" in gradle how to fix it.
…r updating the requirements.txt
devinrsmith
force-pushed
the
docker/runtime-base
branch
from
d67c328
to
1284416
Compare
niloc132
approved these changes
Nov 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.