Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dh-defaults.prop either needs to be replaced by grpc-api.prop or cleaned up for DHC #1732

Closed
jmao-denver opened this issue Dec 22, 2021 · 1 comment · Fixed by #1752
Closed

dh-defaults.prop either needs to be replaced by grpc-api.prop or cleaned up for DHC #1732

jmao-denver opened this issue Dec 22, 2021 · 1 comment · Fixed by #1752
Assignees
@niloc132
Labels
bug Something isn't working triage
Milestone
Jan 2022

Comments

@jmao-denver
Copy link
Contributor

dh-defaults.prop contains a lot of properties that don't apply to DHC and is used in certain projects and tests. grpc-api.prop is much cleaner and more relevant.
@jmao-denver jmao-denver added bug Something isn't working triage labels Dec 22, 2021
@jmao-denver jmao-denver added this to the Dec 2021 milestone Dec 22, 2021
@rcaudy
Copy link
Member

rcaudy commented Dec 22, 2021

I'm not sure this is so, nor do I think we should strictly replace dh-defaults.prop with grpc-api.prop.
We absolutely should remove defunct properties, however.

niloc132 added a commit to niloc132/deephaven-core that referenced this issue Dec 29, 2021
@niloc132
Unify prop files for builds and production
a3cf39c 
Fixes deephaven#1732
@pete-petey pete-petey modified the milestones: Dec 2021, Backlog Dec 29, 2021
@niloc132 niloc132 mentioned this issue Dec 29, 2021
Merged
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Jan 3, 2022
@niloc132
Unify prop files for builds and production
93bd0e2 
Fixes deephaven#1732
niloc132 added a commit that referenced this issue Jan 3, 2022
@niloc132
Unify prop files for builds and production (#1752)
428d7d7 
Fixes #1732
@niloc132 niloc132 modified the milestones: Backlog, Jan 2022 Jan 4, 2022
mofojed pushed a commit that referenced this issue Jan 26, 2024
@github-actions @deephaven-internal
Update web version 0.60.0 (#5078)
2e747b4 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.60.0

# [0.60.0](deephaven/web-client-ui@v0.59.0...v0.60.0) (2024-01-26)


### Bug Fixes

* Fix useDeferredApi export ([#1742](deephaven/web-client-ui#1742)) ([af5f5f4](deephaven/web-client-ui@af5f5f4))
* Handle undefined DashboardData props ([#1726](deephaven/web-client-ui#1726)) ([45fa929](deephaven/web-client-ui@45fa929586c0b13a738eceaa064b261eecbd8308))(https://github.com/deephaven/web-client-ui/issues/1684) [#1685](deephaven/web-client-ui#1685)
* hcm caret shouldn't be allowed to shrink ([#1733](deephaven/web-client-ui#1733)) ([6547814](deephaven/web-client-ui@6547814))
* keep manually entered value in GoToRow when changing to same column type ([#1743](deephaven/web-client-ui#1743)) ([689a1e2](deephaven/web-client-ui@689a1e2))
* loading spinner finishes before all series load ([#1729](deephaven/web-client-ui#1729)) ([e79297b](deephaven/web-client-ui@e79297b))


### Features

* Add pluginDataMap to redux, add useDashboardPluginData hook ([#1737](deephaven/web-client-ui#1737)) ([e1b4562](deephaven/web-client-ui@e1b4562))
* added shortcut for copying version info and added browser/os to info ([#1739](deephaven/web-client-ui#1739)) ([3312133](deephaven/web-client-ui@3312133))
* Adds icons dhUnderline and dhStrikethrough ([#1732](deephaven/web-client-ui#1732)) ([c6a099d](deephaven/web-client-ui@c6a099d))
* adjust display of  theme palette in styleguide ([#1745](deephaven/web-client-ui#1745)) ([0ab0c93](deephaven/web-client-ui@0ab0c93))
* Create UI to Display Partitioned Tables ([#1663](deephaven/web-client-ui#1663)) ([db219ca](deephaven/web-client-ui@db219ca))
* Default Plotly map colors ([#1721](deephaven/web-client-ui#1721)) ([e8b9f12](deephaven/web-client-ui@e8b9f12))
* double-clicking grid rows should select the row rather than toggle selection twice ([#1740](deephaven/web-client-ui#1740)) ([f892e97](deephaven/web-client-ui@f892e97))
* Multiple dashboards ([#1714](deephaven/web-client-ui#1714)) ([32dde3c](deephaven/web-client-ui@32dde3c))

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

Labels
bug Something isn't working triage
Projects
None yet
Milestone
Jan 2022
Development

Successfully merging a pull request may close this issue.

Unify prop files for builds and production niloc132/deephaven-core
4 participants
@niloc132 @jmao-denver @rcaudy @pete-petey