Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep manually entered value in GoToRow when changing to same column type #1743

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 commented Jan 23, 2024

Testing Methodology

  • Generated a relevant table with 2 integer and 1 string columns
  • GoToRow has a column selector and a field to input the value, the possible configurations are
    • If the column selector has changed types
    • If the field was changed
  • GoToRow should leave the field unmodified if the column selector has changed types and the field was changed, otherwise keep the original behaviour
    • One special case where this is the case AND GoToRow has been toggled, going back to the original behaviour
  • Helper function setColumnAndExpectInputValue to make the changes and do the test

@wusteven815 wusteven815 self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (45fa929) 46.04% compared to head (0980586) 46.03%.

Files Patch % Lines
packages/iris-grid/src/IrisGrid.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
- Coverage   46.04%   46.03%   -0.01%     
==========================================
  Files         621      621              
  Lines       37454    37459       +5     
  Branches     9413     9415       +2     
==========================================
  Hits        17244    17244              
- Misses      20156    20161       +5     
  Partials       54       54              
Flag Coverage Δ
unit 46.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusteven815 wusteven815 marked this pull request as ready for review January 23, 2024 14:51
@wusteven815 wusteven815 requested a review from mofojed January 23, 2024 14:52
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include details in the PR description about how you tested this (e.g. what snippet of code did you use, what scenarios did you test).
Also we should probably reset the gotoValueManuallyChanged flag when isGotoShown is changed (e.g. when the user hides/shows the goto row).

packages/iris-grid/src/IrisGrid.tsx Outdated Show resolved Hide resolved
@wusteven815 wusteven815 requested a review from mofojed January 24, 2024 22:09
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@wusteven815 wusteven815 merged commit 689a1e2 into deephaven:main Jan 25, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@wusteven815 wusteven815 deleted the fix-1562 branch February 6, 2024 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep manually entered value in the GoToRow search when changing columns if the column type is the same
2 participants