-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep manually entered value in GoToRow when changing to same column type #1743
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1743 +/- ##
==========================================
- Coverage 46.04% 46.03% -0.01%
==========================================
Files 621 621
Lines 37454 37459 +5
Branches 9413 9415 +2
==========================================
Hits 17244 17244
- Misses 20156 20161 +5
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include details in the PR description about how you tested this (e.g. what snippet of code did you use, what scenarios did you test).
Also we should probably reset the gotoValueManuallyChanged
flag when isGotoShown
is changed (e.g. when the user hides/shows the goto row).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Testing Methodology
setColumnAndExpectInputValue
to make the changes and do the test