Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust display of theme palette in styleguide #1745

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

dsmmcken
Copy link
Contributor

Note: contains no color or app changes.

  • display styleguide as theme palette in a grid (shows in e2e)
  • re-order blue to be after cyan in code
  • group content-subdued-bg with content-bg (triggers a e2e change)

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (6547814) 46.05% compared to head (bdc11e7) 46.03%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ackages/code-studio/src/styleguide/ThemeColors.tsx 18.18% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1745      +/-   ##
==========================================
- Coverage   46.05%   46.03%   -0.02%     
==========================================
  Files         621      621              
  Lines       37433    37465      +32     
  Branches     9400     9419      +19     
==========================================
+ Hits        17238    17247       +9     
- Misses      20141    20164      +23     
  Partials       54       54              
Flag Coverage Δ
unit 46.03% <18.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I looked at styleguide and new color layout looks good. Looked at DH very high level. Looks as before as expected.

@dsmmcken dsmmcken merged commit 0ab0c93 into main Jan 25, 2024
5 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_theme_reorder branch January 25, 2024 20:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants