blockchain: Explicit block fetch semantics. #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_explicit_fetchblock_semantics
branch
from
6eb9836 to
4b0a9ae
Compare
davecgh
force-pushed
the
blockchain_explicit_fetchblock_semantics
branch
from
4b0a9ae to
cfe328b
Compare
alexlyp
approved these changes
Jan 31, 2018
This makes the semantics of block fetching much more explicit by
introducing a new function named fetchMainChainBlockByHash which only
attempts to the load a block from the main chain block cache and then
falls back to the database. While currently only blocks in the main
chain are in the database, the intention is for future commits to
allow the database to house side chain blocks as well, so having clearly
defined semantics will help make that transition easier to verify.
While here, it also renames {f,F}etchBlockFromHash to {f,F}etchBlockByHash
to be consistent with the naming used by the other existing functions
and updates the comments to better describe the function semantics.
davecgh
force-pushed
the
blockchain_explicit_fetchblock_semantics
branch
from
cfe328b to
31f11b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #998.
This makes the semantics of block fetching much more explicit by introducing a new function named
fetchMainChainBlockByHashwhich only attempts to the load a block from the main chain block cache and then falls back to the database. While currently only blocks in the main chain are in the database, the intention is for future commits to allow the database to house side chain blocks as well, so having clearly defined semantics will help make that transition easier to verify.While here, it also renames
{f,F}etchBlockFromHashto{f,F}etchBlockByHashto be consistent with the naming used by the other existing functions and updates the comments to better describe the function semantics.