blockchain: Store side chain blocks in database. #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_store_side_chain_blocks
branch
from
c2865cd to
6e66b23
Compare
alexlyp
previously approved these changes
Jan 31, 2018
davecgh
force-pushed
the
blockchain_store_side_chain_blocks
branch
from
6e66b23 to
a5b9be8
Compare
dajohi
changed the title
davecgh
force-pushed
the
blockchain_store_side_chain_blocks
branch
3 times, most recently
from
5681e87 to
925ef29
Compare
davecgh
changed the title
alexlyp
approved these changes
Feb 18, 2018
This modifies the blockchain code to store all blocks that have passed proof-of-work and contextual validity tests in the database even if they may ultimately fail to connect. This eliminates the need to store those blocks in memory, allows them to be available as orphans later even if they were never part of the main chain, and helps pave the way toward being able to separate the download logic from the connection logic. Note that it also updates the blockExists function since the code base is currently in the process of changing over to decouple download and connection logic, but not all of the necessary parts are updated yet, to ensure blocks that are in the database, but do not have an associated main chain block index entry, are treated as if they do not exist for the purposes of chain connection and selection logic.
davecgh
force-pushed
the
blockchain_store_side_chain_blocks
branch
from
925ef29 to
d967408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
blockchaincode to store all blocks that have passed proof-of-work and contextual validity tests in the database even if they may ultimately fail to connect.This eliminates the need to store those blocks in memory, allows them to be available as orphans later even if they were never part of the main chain, and helps pave the way toward being able to separate the download logic from the connection logic.
Note that it also updates the
blockExistsfunction since the code base is currently in the process of changing over to decouple download and connection logic, but not all of the necessary parts are updated yet, to ensure blocks that are in the database, but do not have an associated main chain block index entry, are treated as if they do not exist for the purposes of chain connection and selection logic.