blockchain: Pass parent block in connection code. #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_pass_parents
branch
2 times, most recently
from
2743f4a to
c2629b3
Compare
This modifies the block connection code paths to accept the parent block in addition to the block as a parameter versus loading it on demand in the called functions. This makes the dependency more explicit and also ensures it doesn't potentially get loaded multiple times in the reorg case.
davecgh
force-pushed
the
blockchain_pass_parents
branch
from
c2629b3 to
53d0926
Compare
alexlyp
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #997.
This modifies the block connection code paths to accept the parent block in addition to the block as a parameter versus loading it on demand in the called functions. This makes the dependency more explicit and also ensures it doesn't potentially get loaded multiple times in the reorg case.