Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception and added proper logging for groups in the list that… #357

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

FastLee
Copy link
Contributor

@FastLee FastLee commented Oct 2, 2023

Closes #312
Closes #313

@nfx nfx added this to the 1 week milestone Oct 3, 2023
@nfx nfx linked an issue Oct 3, 2023 that may be closed by this pull request
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't modify the list while iterating, as it's one of the most common sources for bugs

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #357 (f9c7516) into main (f3886f7) will decrease coverage by 0.35%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   83.58%   83.23%   -0.35%     
==========================================
  Files          30       30              
  Lines        2254     2285      +31     
  Branches      394      401       +7     
==========================================
+ Hits         1884     1902      +18     
- Misses        285      295      +10     
- Partials       85       88       +3     
Files Coverage Δ
src/databricks/labs/ucx/workspace_access/groups.py 90.27% <100.00%> (-2.75%) ⬇️
...rc/databricks/labs/ucx/workspace_access/manager.py 95.23% <100.00%> (-4.77%) ⬇️

... and 3 files with indirect coverage changes

@FastLee FastLee requested a review from nfx October 3, 2023 16:45
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nfx nfx added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit e516998 Oct 3, 2023
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation ([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have been synchronised to Unity Catalog already or not ([#306](#306)).
* Added a migration state to skip already migrated tables ([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows ([#356](#356)).
* Fixed handling of missing but linked cluster policies. ([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that… ([#357](#357)).
* Skip group migration when no groups are available after preparation step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0 ([#362](#362)).
@nfx nfx mentioned this pull request Oct 3, 2023
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
zpappa pushed a commit that referenced this pull request Oct 4, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
@nfx nfx deleted the fix/missing_group_312 branch October 17, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants