Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a migration state to skip already migrated tables #325

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

william-conti
Copy link
Contributor

Add a migration state to skip already migrated tables using an in-memory state

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #325 (e7ef5db) into main (b81abea) will increase coverage by 0.04%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   83.54%   83.58%   +0.04%     
==========================================
  Files          30       30              
  Lines        2242     2254      +12     
  Branches      389      394       +5     
==========================================
+ Hits         1873     1884      +11     
  Misses        285      285              
- Partials       84       85       +1     
Files Coverage Δ
src/databricks/labs/ucx/hive_metastore/tables.py 94.30% <86.66%> (-0.29%) ⬇️

@nfx nfx changed the title Add migration state Add a migration state to skip already migrated tables using an in-memory state Sep 29, 2023
@nfx nfx enabled auto-merge September 29, 2023 14:17
@nfx nfx disabled auto-merge September 29, 2023 14:17
@nfx nfx added the migrate/managed go/uc/upgrade Upgrade Managed Tables and Jobs label Sep 29, 2023
@nfx nfx changed the title Add a migration state to skip already migrated tables using an in-memory state Added a migration state to skip already migrated tables Sep 29, 2023
@nfx nfx added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit f1db173 Sep 29, 2023
FastLee pushed a commit that referenced this pull request Sep 29, 2023
Add a migration state to skip already migrated tables using an in-memory
state

---------

Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com>
@nfx nfx deleted the add_migration_state branch October 2, 2023 17:20
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation ([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have been synchronised to Unity Catalog already or not ([#306](#306)).
* Added a migration state to skip already migrated tables ([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows ([#356](#356)).
* Fixed handling of missing but linked cluster policies. ([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that… ([#357](#357)).
* Skip group migration when no groups are available after preparation step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0 ([#362](#362)).
@nfx nfx mentioned this pull request Oct 3, 2023
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
zpappa pushed a commit that referenced this pull request Oct 4, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrate/managed go/uc/upgrade Upgrade Managed Tables and Jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants