Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups migration fails if a local group is not found on the account level, when we explicitly select that group in config #312

Closed
mwojtyczka opened this issue Sep 28, 2023 · 7 comments · Fixed by #357
Assignees
Labels
documentation Improvements or additions to documentation migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade

Comments

@mwojtyczka
Copy link
Contributor

mwojtyczka commented Sep 28, 2023

I run the tool with selected group. One of the group did not exist in the account. The tool failed and stopped.

Enclosed stacktrace and standard output.
stacktrace.txt

@nfx
Copy link
Collaborator

nfx commented Sep 28, 2023

At the moment, it's the expected behavior. Run with auto:true with groups config

@nfx nfx changed the title Groups migration fails if a local group is not found on the account level Groups migration fails if a local group is not found on the account level, when we explicitly select that group in config Sep 28, 2023
@nfx nfx added invalid wontfix This will not be worked on documentation Improvements or additions to documentation labels Sep 28, 2023
@mwojtyczka
Copy link
Contributor Author

It would be better if the tool just log the issue without failing.

@nfx
Copy link
Collaborator

nfx commented Sep 28, 2023

@mwojtyczka we could also do that but will it not leave the migration in the incomplete state?

@nfx nfx added migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade and removed invalid labels Sep 28, 2023
@mwojtyczka
Copy link
Contributor Author

mwojtyczka commented Sep 28, 2023

Why? the groups anyway only exists in the workspace. There is nothing we can do if they are not in the account.
Why not to just skip them and continue running for other group.

Does that issue also exist if we run it the tool for all groups (not only selected)?

@nfx nfx removed the wontfix This will not be worked on label Sep 28, 2023
@nfx
Copy link
Collaborator

nfx commented Sep 28, 2023

to properly support this, we have to be able to re-run the group migration step

@zpappa
Copy link

zpappa commented Sep 29, 2023

Agree with @nfx - this should be idempotently runnable.

@nfx nfx added the bug label Oct 2, 2023
@nfx nfx added this to the 1 week milestone Oct 2, 2023
@FastLee
Copy link
Contributor

FastLee commented Oct 2, 2023

@nfx what's the verdict?
Should we validate and log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation migrate/groups Corresponds to Migrate Groups Step of go/uc/upgrade
Projects
Development

Successfully merging a pull request may close this issue.

4 participants