Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16217 test: Update run_local(). #14748

Merged
merged 18 commits into from
Jul 30, 2024
Merged

DAOS-16217 test: Update run_local(). #14748

merged 18 commits into from
Jul 30, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Jul 11, 2024

Update the current run_local() command to return an object similar to run_remote() to allow them to be used interchangeably.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-16217 test: Update run_local().
762360a 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested review from a team as code owners July 11, 2024 19:41
@github-actions GitHub Actions
Copy link

Ticket title is 'ftest: Update run_local() to return same object type as run_remote()'
Status is 'In Progress'
Labels: 'daos_framework'
https://daosio.atlassian.net/browse/DAOS-16217

@phender
Fix searching run_local output.
7746e61 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
daltonbohning
daltonbohning reviewed Jul 11, 2024
View reviewed changes
src/tests/ftest/util/run_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/util/run_utils.py Outdated
Comment on lines 263 to 266
source_keys = NodeSet.fromlist(hosts)
data_keys = NodeSet()
for _, keys in data:
data_keys.add(NodeSet.fromlist(keys))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI - I recently discovered this to flatten lists. (might need some type adjustments here, but not asking you to change anyway. just FYI)

>>> list_of_lists = [['a','b'], ['c','d']]
>>> default_sum = []
>>> sum(list_of_lists, default_sum)
['a', 'b', 'c', 'd']

src/tests/ftest/util/run_utils.py Show resolved Hide resolved
src/tests/ftest/verify_perms.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/2/execution/node/798/log

@phender
Applying feddback and fixes.
b58d973 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/3/execution/node/798/log

phender added 3 commits July 12, 2024 16:45
@phender
Fix run_utils.py and harness/unit.py.
58f5467 
- Add collection of command out for timed out run_remote() commands

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender
Use ClusterShell.Task to run local commands.
c2a3472 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender
Fix docstring.
e4ce9fe 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/6/execution/node/799/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/6/execution/node/1020/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/6/execution/node/1159/log

@phender
Fix joined_sterr/out handling of empty strings.
097c539 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/7/execution/node/799/log

phender added 2 commits July 16, 2024 12:05
@phender
Merge branch 'master' into pahender/DAOS-16217
4c7045c
@phender
Ensure joined_stdout/err is in an expected order for unit testing.
e68a2f4 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/8/execution/node/823/log

@phender
Fix joined_* comapre.
6ec9255 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/9/execution/node/799/log

@phender phender requested a review from daltonbohning July 17, 2024 02:41
@phender
Pass expecyed joined stdout/stderr strings to unit test.
df32ceb 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14748/10/testReport/

daltonbohning
daltonbohning reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting is failing

src/tests/ftest/process_core_files.py Outdated
Comment on lines 385 to 386
if not result.passed:
raise RunException(f"Error running {command}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this fails, name, version, release, epoch = result.joined_stdout.split() would probably be wrong and this function would still return package_info with weird data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, code updated.

phender added 2 commits July 17, 2024 13:15
@phender
Fix test_harness_unit_run_remote_homogeneous
d5b18b1 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender
Apply feedback.
7159532 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested a review from daltonbohning July 17, 2024 17:59
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/13/execution/node/795/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/14/execution/node/1158/log

daltonbohning
daltonbohning reviewed Jul 22, 2024
View reviewed changes
src/tests/ftest/verify_perms.py
return run_local(logger, path, check=True, verbose=False).returncode == 0
except RunException:
return False
return run_local(logger, path, verbose=False).passed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if the new definition of run_local is slower than the older, which might explain why the mu_perms test times out now.
In this daily testing run, the same command took 1min 28s, with a 2 min timeout
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/daily-testing/214/artifact/Functional%20on%20EL%208/dfuse/mu_perms.py/job.log

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, maybe this should just use

try:
    return subprocess.run(path, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE, check=True).returncode == 0
except subprocess.CalledProcessError:
    return False

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be VM slowness like https://daosio.atlassian.net/browse/DAOS-15402 where in:

2024-07-18 20:04:36,287 test             L0530 INFO | START 1-./dfuse/mu_perms.py:DfuseMUPerms.test_dfuse_mu_perms;run-container-dfuse-dfuse_with_caching-hosts-pool-server_config-engines-0-storage-0-test_dfuse_mu_perms_cache-verify_perms-5a8a
2024-07-18 20:04:37,835 test             L0473 INFO | ==> Step 1: setUp(): Starting servers [elapsed since last step: 1.55s]
2024-07-18 20:05:40,815 test             L0473 INFO | ==> Step 2: setUp(): Starting agents [elapsed since last step: 62.98s]
2024-07-18 20:06:01,165 test             L0473 INFO | ==> Step 3: setUp(): Setup complete [elapsed since last step: 20.35s]
2024-07-18 20:06:12,590 test             L0473 INFO | ==> Step 4: Verifying simple file permissions on /tmp/daos_dfuse_test_dfuse_mu_perms_1/test_file [elapsed since last step: 11.43s]
2024-07-18 20:06:39,888 test             L0473 INFO | ==> Step 5: Verifying simple dir permissions on /tmp/daos_dfuse_test_dfuse_mu_perms_1/test_dir [elapsed since last step: 27.30s]
2024-07-18 20:07:07,161 test             L0473 INFO | ==> Step 6: Verifying real file permissions on /tmp/daos_dfuse_test_dfuse_mu_perms_1/test_file [elapsed since last step: 27.27s]
2024-07-18 20:09:01,790 test             L0473 INFO | ==> Step 7: Verifying real dir permissions on /tmp/daos_dfuse_test_dfuse_mu_perms_1/test_dir [elapsed since last step: 114.63s]
2024-07-18 20:09:40,306 test             L0473 INFO | ==> Step 8: Creating directory: %s [elapsed since last step: 38.52s]
2024-07-18 20:09:40,704 test             L0473 INFO | ==> Step 9: Giving ownership to daos_test_user_x2 [elapsed since last step: 0.40s]
2024-07-18 20:09:41,456 test             L0473 INFO | ==> Step 10: Verifying real file permissions on /tmp/daos_dfuse_test_dfuse_mu_perms_1/dir1/test_file [elapsed since last step: 0.75s]
2024-07-18 20:11:41,625 test             L0473 INFO | ==> Step 11: tearDown(): Called after test completion (test timeout: 570s, elapsed: 425.34s, remaining: 144.66s) [elapsed since last step: 120.17s]
2024-07-18 20:11:55,161 test             L0933 ERROR| ERROR 1-./dfuse/mu_perms.py:DfuseMUPerms.test_dfuse_mu_perms;run-container-dfuse-dfuse_with_caching-hosts-pool-server_config-engines-0-storage-0-test_dfuse_mu_perms_cache-verify_perms-5a8a -> CommandFailure: verify_perms.py failed on: wolf-102vm3

We see that the starting the servers took 62.98s - longer than the norm. Maybe we should run the command with a larger or no timeout?

@phender
Copy link
Contributor Author

phender commented Jul 24, 2024 •
edited
Loading

The HW Large failures in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14748/14/testReport/ can be attributed to a HW issue with wolf-222:

2024-07-19 06:43:59,000 process          L0416 DEBUG| [stderr] ERROR: Errors:
2024-07-19 06:43:59,000 process          L0416 DEBUG| [stderr]   Hosts    Error                                                                 
2024-07-19 06:43:59,001 process          L0416 DEBUG| [stderr]   -----    -----                                                                 
2024-07-19 06:43:59,001 process          L0416 DEBUG| [stderr]   wolf-222 storage: code = 304 description = "NVMe SSD [0000:65:00.0] not found" 
2024-07-19 06:43:59,001 process          L0416 DEBUG| [stderr]   wolf-222 storage: code = 304 description = "NVMe SSD [0000:a5:00.0] not found"

and also https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14748/14/artifact/Functional%20Hardware%20Large/daos_test/dfs.py which failed to start the engines on wolf-222.

Issues with the cluster containing wolf-222 were also seen in https://daosio.atlassian.net/browse/DAOS-16280.

@phender phender requested a review from mjean308 July 24, 2024 21:24
mjean308
mjean308 previously approved these changes Jul 24, 2024
View reviewed changes
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14748/15/execution/node/810/log

phender added 2 commits July 25, 2024 14:45
@phender
Merge branch 'master' into pahender/DAOS-16217
b61bd10 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender
Remove the default timeout from the new run_local().
544ff18 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender dismissed stale reviews from mjean308 and daltonbohning via 544ff18 July 25, 2024 18:53
@phender
Undo last change and increase verify_perms.py timeout.
bd0abe8 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14748/17/testReport/

@daltonbohning
Copy link
Contributor

The only failure is test_always_fails, which is expected to fail to verify failure paths
https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-14748/17/tests

@daltonbohning daltonbohning requested a review from mjean308 July 30, 2024 15:16
@daltonbohning daltonbohning requested a review from a team July 30, 2024 16:13
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 30, 2024
@daltonbohning daltonbohning merged commit ed96c9d into master Jul 30, 2024
45 of 47 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16217 branch July 30, 2024 16:15
daltonbohning pushed a commit that referenced this pull request Jul 30, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748)
c5d62db 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 2, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748)
5726938 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 2, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748) #14866
d4186f3 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 5, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748)
7bcdf83 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Also include #14870
Handle any avocado run raised exception

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 7, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748) #14866
2bcde91 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 8, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748)
d8f83f1 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14882
Use subprocess.run() for run_local()

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 8, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748) #14866
20416f2 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14882
Use subprocess.run() for run_local()

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
phender added a commit that referenced this pull request Aug 12, 2024
@daltonbohning @phender
DAOS-16217 test: Update run_local(). (#14748) (#14866)
f390961 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14882
Use subprocess.run() for run_local()

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Co-authored-by: Phil Henderson <phillip.henderson@intel.com>
@cdavis28 cdavis28 mentioned this pull request Aug 12, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjean308 mjean308 mjean308 approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phender @daosbuild1 @daltonbohning @mjean308