Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16217 test: Use subprocess.run() for run_local() #14882

Merged
merged 4 commits into from
Aug 8, 2024
Merged

DAOS-16217 test: Use subprocess.run() for run_local() #14882

merged 4 commits into from
Aug 8, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Aug 6, 2024

Restore using subprocess.run() for the run_local() command to regain execution speed and simultaneous command output. Retain the CommandResult return value shared with run_remote().

Test-tag: pr HarnessUnitTest DfuseMUPerms

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-16217 test: Use subprocess.run() for run_local()
5dc329d 
Restore using subprocess.run() for the run_local() command to regain
execution speed and simultaneous command output.  Retain the
CommandResult return value shared with run_remote().

Test-tag: pr HarnessUnitTest DfuseMUPerms

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested review from a team as code owners August 6, 2024 20:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Ticket title is 'ftest: Update run_local() to return same object type as run_remote()'
Status is 'Awaiting backport'
Labels: 'daos_framework'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16217

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Aug 6, 2024
@phender
Copy link
Contributor Author

phender commented Aug 6, 2024

Confirmed via manual testing that the test output is displayed when running launch.py w/o -s (https://daosio.atlassian.net/browse/DAOS-16295).

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14882/2/testReport/

phender added 3 commits August 7, 2024 14:55
@phender
Fix for stdout/stderr separation.
42d9028 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest DfuseMUPerms

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender
Merge branch 'master' into pahender/DAOS-16217_subprocess
ec31b20
@phender
Apply feedback.
33a7238 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest DfuseMUPerms

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested a review from daltonbohning August 7, 2024 20:50
@phender
Copy link
Contributor Author

phender commented Aug 8, 2024

All tests passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14882/4/testReport/

The remaining test timeout in 1-./dfuse/mu_perms.py:DfuseMUPerms.test_dfuse_mu_perms was 68.20s in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14882/4/artifact/Functional%20on%20EL%208.8/dfuse/mu_perms.py/steps.log

@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 8, 2024
@phender phender requested a review from a team August 8, 2024 17:54
@daltonbohning daltonbohning merged commit f6d67b1 into master Aug 8, 2024
49 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16217_subprocess branch August 8, 2024 17:57
daltonbohning pushed a commit that referenced this pull request Aug 8, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748)
d8f83f1 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14882
Use subprocess.run() for run_local()

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning mentioned this pull request Aug 8, 2024
Merged
18 tasks
daltonbohning pushed a commit that referenced this pull request Aug 8, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748) #14866
20416f2 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14882
Use subprocess.run() for run_local()

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
phender added a commit that referenced this pull request Aug 12, 2024
@daltonbohning @phender
DAOS-16217 test: Update run_local(). (#14748) (#14866)
f390961 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14882
Use subprocess.run() for run_local()

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Co-authored-by: Phil Henderson <phillip.henderson@intel.com>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjean308 mjean308 mjean308 approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phender @daosbuild1 @daltonbohning @mjean308