Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16295 test: fix streaming stdout when running launch.py locally #14848

Merged
merged 1 commit into from
Aug 2, 2024
Merged

DAOS-16295 test: fix streaming stdout when running launch.py locally #14848

merged 1 commit into from
Aug 2, 2024

Conversation

daltonbohning
Copy link
Contributor

Use subprocess.run instead of run_local so test output is printed while running.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Jul 30, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'ftest: fix streaming stdout when running launch.py locally'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16295

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14848/1/execution/node/1129/log

@daltonbohning
DAOS-16295 test: fix streaming stdout when running launch.py locally
f34831e 
Use subprocess.run instead of run_local so test output is printed while
running.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14848/2/execution/node/1098/log

@daltonbohning daltonbohning marked this pull request as ready for review August 1, 2024 14:12
@daltonbohning daltonbohning requested review from a team as code owners August 1, 2024 14:12
@daltonbohning
Copy link
Contributor Author

Failure in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-14848/2/pipeline
is https://daosio.atlassian.net/browse/DAOS-15547

@daltonbohning daltonbohning requested a review from a team August 2, 2024 14:29
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 2, 2024
@daltonbohning daltonbohning merged commit 51e4429 into master Aug 2, 2024
45 of 47 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16295 branch August 2, 2024 14:31
daltonbohning pushed a commit that referenced this pull request Aug 2, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748)
5726938 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning mentioned this pull request Aug 2, 2024
Merged
18 tasks
daltonbohning pushed a commit that referenced this pull request Aug 2, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748) #14866
d4186f3 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 5, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748)
7bcdf83 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Also include #14870
Handle any avocado run raised exception

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 7, 2024
@phender @daltonbohning
DAOS-16217 test: Update run_local(). (#14748) #14866
2bcde91 
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpadma2 rpadma2 rpadma2 approved these changes

@shimizukko shimizukko shimizukko approved these changes

@mjean308 mjean308 Awaiting requested review from mjean308

@phender phender Awaiting requested review from phender

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daltonbohning @daosbuild1 @shimizukko @rpadma2