Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16011 : Valgrind suppressions due to update Go to 1.22.3 #14566

Merged
merged 2 commits into from
Jun 13, 2024
Merged

DAOS-16011 : Valgrind suppressions due to update Go to 1.22.3 #14566

merged 2 commits into from
Jun 13, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jun 13, 2024

For more information see #14564

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@grom72
DAOS-16011 : Valgrind suppressions due to update Go to 1.22.3
7b4eb9c 
Skip HW validation as it is irrelevant.
Skip-func-hw-test: true

Priority: 2
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 added priority Ticket has high priority (automatically managed) forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. go Pull requests that update Go code release-2.6 labels Jun 13, 2024
@github-actions GitHub Actions
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-16011

@grom72 grom72 marked this pull request as ready for review June 13, 2024 15:04
@grom72 grom72 requested review from a team as code owners June 13, 2024 15:04
@grom72 grom72 requested a review from JohnMalmberg June 13, 2024 15:45
@grom72
Skip HW tests as they are unrelated to this change.
3106742 
Skip-func-hw-test: true

Priority: 2
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@phender
Copy link
Contributor

phender commented Jun 13, 2024

All tests (excluding intentionally skipped functional HW tests) passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14566/2/

@phender phender merged commit 4338021 into release/2.6 Jun 13, 2024
30 of 32 checks passed
@phender phender deleted the grom72/DAOS-16011-2.6 branch June 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanabarr tanabarr tanabarr approved these changes

@JohnMalmberg JohnMalmberg JohnMalmberg approved these changes

@ryon-jensen ryon-jensen ryon-jensen approved these changes

@brianjmurrell brianjmurrell Awaiting requested review from brianjmurrell

@kjacque kjacque Awaiting requested review from kjacque

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. go Pull requests that update Go code priority Ticket has high priority (automatically managed) release-2.6
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grom72 @phender @tanabarr @JohnMalmberg @ryon-jensen