Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16011 : Valgrind suppressions due to update Go to 1.22.3 #14564

Merged
merged 1 commit into from
Jun 13, 2024
Merged

DAOS-16011 : Valgrind suppressions due to update Go to 1.22.3 #14564

merged 1 commit into from
Jun 13, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jun 13, 2024

Valgrind suppression for go-build-toolchain package v.1.22.3
Validation has been done via go-build-toolchain PR-25 with pragma Test-master-branch: grom72/DAOS-16011
The results are here:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-go-build-toolchain-PR-25-master/16/testReport/

Reference build w/o Valgrind suppressions:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-go-build-toolchain-PR-25-master/13/testReport/

The scope of validation only to SW tests (where Valgrind is used).

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@grom72
DAOS-16011 : Valgrind suppressions due to update Go to 1.22.3
86ed305 
Skip HW validation as it is irrelevant.
Skip-func-hw-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 added priority Ticket has high priority (automatically managed) forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. release-2.6 labels Jun 13, 2024
@grom72 grom72 requested review from a team as code owners June 13, 2024 11:39
@github-actions GitHub Actions
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-16011

@grom72 grom72 mentioned this pull request Jun 13, 2024
Merged
18 tasks
@grom72 grom72 added go Pull requests that update Go code and removed release-2.6 labels Jun 13, 2024
kjacque
kjacque approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@kjacque kjacque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grom72 grom72 requested a review from a team June 13, 2024 15:02
@grom72
Copy link
Contributor Author

grom72 commented Jun 13, 2024

@daos-stack/daos-gatekeeper Functional Hardware tests are intentionally disabled as this PR does not make any impact on these areas of tests.

@phender phender merged commit c7c067f into master Jun 13, 2024
50 checks passed
@phender phender deleted the grom72/DAOS-16011 branch June 13, 2024 16:41
jolivier23 pushed a commit that referenced this pull request Jun 18, 2024
@grom72 @jolivier23
DAOS-16011 : Valgrind suppressions due to update Go to 1.22.3 (#14564)
f2ce741 
Required-githooks: true

Change-Id: I3458d7a4c250e39adb580486c1096e4bb8e9b704
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
jolivier23 added a commit that referenced this pull request Jun 18, 2024
@jolivier23
DAOS-16011 : Valgrind suppressions due to update Go to 1.22.3 (#14564) (
9c5c222 
#14608)

Change-Id: I3458d7a4c250e39adb580486c1096e4bb8e9b704

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjacque kjacque kjacque approved these changes

@tanabarr tanabarr tanabarr approved these changes

@mjmac mjmac Awaiting requested review from mjmac

@brianjmurrell brianjmurrell Awaiting requested review from brianjmurrell

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. go Pull requests that update Go code priority Ticket has high priority (automatically managed) release-2.6
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grom72 @tanabarr @kjacque @phender