Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: displayed ui when gifted #4169

Merged
merged 3 commits into from
Feb 10, 2025
Merged

fix: displayed ui when gifted #4169

merged 3 commits into from
Feb 10, 2025

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Feb 10, 2025

Changes

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://fix-gifted.preview.app.daily.dev

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Feb 10, 2025 3:40pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Feb 10, 2025 3:40pm

staleTime: StaleTime.Default,
});

if (isLoading) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isPending now

@sshanzel sshanzel merged commit 0de2cc8 into MI-746-gifting-plus Feb 10, 2025
10 checks passed
@sshanzel sshanzel deleted the fix-gifted branch February 10, 2025 15:40
ilasw added a commit that referenced this pull request Feb 11, 2025
* feat: gift user modal (#4091)

* feat: add gift option to profile menu (#4085)

* feat: Add gift option to profile menu

* feat: gift user modal

* add the modal

* feat: search user with mention

* tmp: show modal

* fix: on change handler

* fix: debounce

* fix: keyboard navigation

* fix: arrow and on focus

* feat: on hover, set selected

* fix: ref

* fix: index

* fix: overlay append

* fix: interactivity

* fix: on close

* fix: selected ui

* fix: gap

* fix: alignment

* fix: roundness

* fix: TODO

* fix: checking disabled

* Revert "tmp: show modal"

This reverts commit 3f53473.

* fix: missing context provider

* fix: modal pricing

* fix: missing preselected user

---------

Co-authored-by: Lee Hansel Solevilla <sshanzel@yahoo.com>
Co-authored-by: Lee Hansel Solevilla <13744167+sshanzel@users.noreply.github.com>

* feat: gift plus in invite friends section (#4097)

* feat: Add gift option to profile menu

* feat: gift user modal

* add the modal

* feat: search user with mention

* tmp: show modal

* fix: on change handler

* fix: debounce

* fix: keyboard navigation

* fix: arrow and on focus

* feat: on hover, set selected

* fix: ref

* fix: index

* fix: overlay append

* fix: interactivity

* fix: on close

* fix: selected ui

* fix: gap

* fix: alignment

* fix: roundness

* fix: TODO

* fix: checking disabled

* Revert "tmp: show modal"

This reverts commit 3f53473.

* fix: missing context provider

* fix: modal pricing

* fix: missing preselected user

* feat: gift plus in invite friends section

---------

Co-authored-by: Lee Hansel Solevilla <sshanzel@yahoo.com>
Co-authored-by: Lee Hansel Solevilla <13744167+sshanzel@users.noreply.github.com>

* feat: add gift button to dropdowns (#4092)

* feat: Add gift option to profile menu

* feat: gift user modal

* add the modal

* feat: Add gift butto to dropdowns

* feat: search user with mention

* tmp: show modal

* fix: on change handler

* fix: debounce

* fix: keyboard navigation

* fix: arrow and on focus

* feat: on hover, set selected

* fix: ref

* fix: index

* fix: overlay append

* fix: interactivity

* fix: on close

* fix: selected ui

* fix: gap

* fix: alignment

* fix: roundness

* fix: TODO

* fix: checking disabled

* Revert "tmp: show modal"

This reverts commit 3f53473.

* fix: missing context provider

* fix: modal pricing

* fix: missing preselected user

* chore: update blocker

---------

Co-authored-by: Lee Hansel Solevilla <sshanzel@yahoo.com>
Co-authored-by: Lee Hansel Solevilla <13744167+sshanzel@users.noreply.github.com>

* refactor: plus page to allow gifting another user (#4108)

* fix: usage of apps id from paddle (#4123)

* fix: gifting while user is a Plus member already (#4131)

* feat: notification modal opening logic (#4132)

* feat: gift tracking (#4135)

* feat: add missing gifter_id param in checkout (#4137)

* fix: merge issues

* fix: missing gifter id

* fix: is disabled

* refactor: unnecessary const

* revert: privacy to all

* fix: gift subscription feedback (#4160)

* fix: displayed ui when gifted (#4169)

* fix: typo

---------

Co-authored-by: Lee Hansel Solevilla <13744167+sshanzel@users.noreply.github.com>
Co-authored-by: Amar Trebinjac <36768584+AmarTrebinjac@users.noreply.github.com>
Co-authored-by: Lee Hansel Solevilla <sshanzel@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants