fix: usage of apps id from paddle #4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshanzel
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
nensidosari and
AmarTrebinjac
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
sshanzel
commented
Jan 29, 2025
Comment on lines
+197
to
+199
| if (earlyAdopter?.value) { | ||
| return earlyAdopter.value; | ||
| } |
There was a problem hiding this comment.
To support backwards compat and existing would still work as intended, we would only early return when it is actually found.
There was a problem hiding this comment.
From Chris' sandbox, this has the right custom value already 🙏
ilasw
approved these changes
Jan 29, 2025
ilasw
added a commit
that referenced
this pull request
Feb 11, 2025
* feat: gift user modal (#4091) * feat: add gift option to profile menu (#4085) * feat: Add gift option to profile menu * feat: gift user modal * add the modal * feat: search user with mention * tmp: show modal * fix: on change handler * fix: debounce * fix: keyboard navigation * fix: arrow and on focus * feat: on hover, set selected * fix: ref * fix: index * fix: overlay append * fix: interactivity * fix: on close * fix: selected ui * fix: gap * fix: alignment * fix: roundness * fix: TODO * fix: checking disabled * Revert "tmp: show modal" This reverts commit 3f53473. * fix: missing context provider * fix: modal pricing * fix: missing preselected user --------- Co-authored-by: Lee Hansel Solevilla <sshanzel@yahoo.com> Co-authored-by: Lee Hansel Solevilla <13744167+sshanzel@users.noreply.github.com> * feat: gift plus in invite friends section (#4097) * feat: Add gift option to profile menu * feat: gift user modal * add the modal * feat: search user with mention * tmp: show modal * fix: on change handler * fix: debounce * fix: keyboard navigation * fix: arrow and on focus * feat: on hover, set selected * fix: ref * fix: index * fix: overlay append * fix: interactivity * fix: on close * fix: selected ui * fix: gap * fix: alignment * fix: roundness * fix: TODO * fix: checking disabled * Revert "tmp: show modal" This reverts commit 3f53473. * fix: missing context provider * fix: modal pricing * fix: missing preselected user * feat: gift plus in invite friends section --------- Co-authored-by: Lee Hansel Solevilla <sshanzel@yahoo.com> Co-authored-by: Lee Hansel Solevilla <13744167+sshanzel@users.noreply.github.com> * feat: add gift button to dropdowns (#4092) * feat: Add gift option to profile menu * feat: gift user modal * add the modal * feat: Add gift butto to dropdowns * feat: search user with mention * tmp: show modal * fix: on change handler * fix: debounce * fix: keyboard navigation * fix: arrow and on focus * feat: on hover, set selected * fix: ref * fix: index * fix: overlay append * fix: interactivity * fix: on close * fix: selected ui * fix: gap * fix: alignment * fix: roundness * fix: TODO * fix: checking disabled * Revert "tmp: show modal" This reverts commit 3f53473. * fix: missing context provider * fix: modal pricing * fix: missing preselected user * chore: update blocker --------- Co-authored-by: Lee Hansel Solevilla <sshanzel@yahoo.com> Co-authored-by: Lee Hansel Solevilla <13744167+sshanzel@users.noreply.github.com> * refactor: plus page to allow gifting another user (#4108) * fix: usage of apps id from paddle (#4123) * fix: gifting while user is a Plus member already (#4131) * feat: notification modal opening logic (#4132) * feat: gift tracking (#4135) * feat: add missing gifter_id param in checkout (#4137) * fix: merge issues * fix: missing gifter id * fix: is disabled * refactor: unnecessary const * revert: privacy to all * fix: gift subscription feedback (#4160) * fix: displayed ui when gifted (#4169) * fix: typo --------- Co-authored-by: Lee Hansel Solevilla <13744167+sshanzel@users.noreply.github.com> Co-authored-by: Amar Trebinjac <36768584+AmarTrebinjac@users.noreply.github.com> Co-authored-by: Lee Hansel Solevilla <sshanzel@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://refactor-appsid.preview.app.daily.dev