Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gift tracking #4135

Merged
merged 8 commits into from
Feb 4, 2025
Merged

feat: gift tracking #4135

merged 8 commits into from
Feb 4, 2025

Conversation

ilasw
Copy link
Contributor

@ilasw ilasw commented Jan 31, 2025

Changes

Events

Did you introduce any new tracking events?

image
Checkout event have been added in #4137

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://feat-gift-tracking.preview.app.daily.dev

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Feb 4, 2025 11:26am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Feb 4, 2025 11:26am

Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have anything to add. Just kindly wait for @idoshamun's review too for the analytics events.

Copy link
Contributor

@capJavert capJavert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also please update Events part of PR template

Copy link
Member

@idoshamun idoshamun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the complete gift checkout event

Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

@sshanzel
Copy link
Member

sshanzel commented Feb 3, 2025

I don't see the complete gift checkout event

The complete event should now be found in the other PR: #4137

@sshanzel sshanzel requested a review from idoshamun February 3, 2025 16:01
@sshanzel sshanzel merged commit b67742d into MI-746-gifting-plus Feb 4, 2025
10 checks passed
@sshanzel sshanzel deleted the feat-gift-tracking branch February 4, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants