-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v12 examples to 12.4.1 #747
Update v12 examples to 12.4.1 #747
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
aeae721
to
3c8a252
Compare
Please review and merge this update to the latest Cypress version 12.4.0. Thanks! |
3c8a252
to
321a9bc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
321a9bc
to
6c3456f
Compare
This PR, which originally updated the examples to 12.4.0, now updates them to Cypress 12.4.1 instead. |
6c3456f
to
069fe98
Compare
All tests pass, so this PR is ready again for review and merge. |
03394f1
to
4455266
Compare
The main reason for wanting to update to Cypress >= 12.4.0 is the support of Vite 4, which enables a new up-to-date setup of Component Testing to be created. |
4455266
to
3e83b32
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine so we can move the other PRs along.
Moving forward we should be able to expand and leverage the npm-install-examples
script. That's worth a separate task it seems.
Good idea! I will open a new issue to make the suggestion of completing the automation of upgrading to the latest Cypress version so that all types of package managers are covered i.e. add |
There was an error reported in run 7005024879 when merging this PR. It appears to be a GitHub issue not caused by the repo code, so no special action necessary:
|
I reran this as a test for another issue and it's passing now. Will keep an eye on it for flake |
|
🎉 This PR is included in version 5.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR updates examples to use the latest Cypress version
12.4.0 released on Jan 24, 2023.12.4.1 released on Jan 27, 2023.
Each of the test directories in examples, apart from examples/v9, is upgraded to use Cypress 12.4.1.
An issue caused by PR Restructure v9 and v10 examples #727 concerning renaming of the script scripts/npm-install-examples.sh is corrected.
The npm-based examples are updated using:
npm run install-deps
This updates
package.json
to include"cypress": "12.4.1"
with exact version number as determined by .npmrc.examples/start-and-yarn-workspaces is updated using:
yarn upgrade-interactive --latest
examples/install-command is updated using:
yarn add cypress -D
examples/basic-pnpm is updated using:
pnpm update --latest
Edit the run command in .github/workflows/example-install-only.yml
run: npm i cypress@12.x.x