Update wait-on-vite example to current versions #758
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
MikeMcC399
force-pushed
the
update/wait-on-vite
branch
2 times, most recently
from
1d5d312
to
0a0a13a
Compare
updates wait-on-vite to use Vite 4 updates v9/wait-on-vite to use Vite 3 app code is standard from npm create vite port is changed to default 5173
MikeMcC399
force-pushed
the
update/wait-on-vite
branch
from
0a0a13a
to
4c04ed2
Compare
|
This looks goo @MikeMcC399. Have you uncovered any intel on the errors indicated here? https://github.com/cypress-io/github-action/actions/runs/4143979840/jobs/7166507634#step:3:47 |
This is a general Cypress issue related to running under GitHub runners or Docker containers. Cypress 12.xUnder Cypress 12.4.1 with and
Cypress 9.7.0Under Cypress 9.7.0 with ubuntu-20.04 and ubuntu-22.04 an additional message "ERROR:sandbox_linux.cc(377)" is output: Neither errors prevent Cypress tests from succeeding.
|
|
We generally won't backport any fixes to olde versions of Cypress - since that one you are referring to is purely cosmetic, non a blocker to running tests, I think it's fine to move forward as is. |
|
Thanks for clarifying @MikeMcC399! |
|
It seems that there is a recording clash happening when multiple actions, like ones triggered by a PR here, and others triggered by the renovate process are running in parallel. This causes test failures in Could you perhaps change the renovate schedule so it doesn't try to create new PRs at the same time as you would potentially be merging PRs? |
|
Yes. I've seen this happen before, but haven't had the bandwidth to get to the root cause. Will get a look at renovate config as a possible solution. |
|
🎉 This PR is included in version 5.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR implements the suggestion from issue #756 "examples/wait-on-vite uses vite 2 beta" to update the Vite version to a non-beta version.
For the legacy (v9) and current config example versions, the wait-on-vite app is replaced by the standard example created by
npm create vitewith options Vanilla and JavaScript.examples/wait-on-vite is updated using
npm create vite@4.examples/v9/wait-on-vite is updated using
npm create vite@3.In .github/workflows/example-wait-on.yml changes are made to align with default Vite values / settings:
Verification
Local test
Execute:
cd examples/wait-on-vite npm ci npm run devCheck that server announces itself with VITE v4.0.4.
In a separate terminal window execute:
ensuring that the Cypress test runs successfully.
In the server terminal window, press q to quit the server.
cd ../v9/wait-on-vite npm ci npm run devCheck that server announces itself with VITE v3.2.5.
Switch to the separate test terminal window and execute:
and ensure that the Cypress test for the v9 version runs successfully.
GitHub Action test
Run .github/workflows/example-wait-on.yml and check that jobs
wait-on-vite-v9andwait-on-viteshow success.